From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id B929823A44
	for <tarantool-patches@freelists.org>; Fri,  4 May 2018 10:12:37 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Y3_EGKlLEc9l for <tarantool-patches@freelists.org>;
	Fri,  4 May 2018 10:12:37 -0400 (EDT)
Received: from smtp50.i.mail.ru (smtp50.i.mail.ru [94.100.177.110])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 739C623AFB
	for <tarantool-patches@freelists.org>; Fri,  4 May 2018 10:12:37 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 4/4] sql: fix SAVEPOINT RELEASE
 statement
References: <cover.1525368399.git.korablev@tarantool.org>
 <db45505203365b8dce7890b9daf59584371b070d.1525368399.git.korablev@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <981f3a25-f813-884e-d36f-63794af445fa@tarantool.org>
Date: Fri, 4 May 2018 17:12:35 +0300
MIME-Version: 1.0
In-Reply-To: <db45505203365b8dce7890b9daf59584371b070d.1525368399.git.korablev@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

Hello. Thanks for contributing!

See below 2 comments.

1. Lets do not create a new test file on each issue.

On 03/05/2018 21:49, Nikita Pettik wrote:
> Before this patch SAVEPOINT RELEASE statement always raised error,
> due to SQLite's obsolete code. Now it has been removed, and
> SAVEPOINT RELEASE works as desired.
> 
> Closes #3379
> ---
>   src/box/sql/vdbe.c                           |  7 -----
>   test/sql/gh-3379-release-savepoints.result   | 40 ++++++++++++++++++++++++++++
>   test/sql/gh-3379-release-savepoints.test.lua | 26 ++++++++++++++++++
>   3 files changed, 66 insertions(+), 7 deletions(-)
>   create mode 100644 test/sql/gh-3379-release-savepoints.result
>   create mode 100644 test/sql/gh-3379-release-savepoints.test.lua
> 
> diff --git a/test/sql/gh-3379-release-savepoints.result b/test/sql/gh-3379-release-savepoints.result
> new file mode 100644
> index 000000000..5f5804b66
> --- /dev/null
> +++ b/test/sql/gh-3379-release-savepoints.result
> @@ -0,0 +1,40 @@
> +test_run = require('test_run').new()
> +---
> +...
> +test_run:cmd("setopt delimiter ';'")
> +---
> +- true
> +...
> +-- These tests check that release of SQL savepoints works as desired.
> +--
> +-- box.cfg()

2. Garbage diff.