From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 0723826263 for ; Tue, 10 Jul 2018 10:59:17 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id K0ZLNJLo0Rdi for ; Tue, 10 Jul 2018 10:59:16 -0400 (EDT) Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id B872726241 for ; Tue, 10 Jul 2018 10:59:16 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/2] sql: remove OP_LoadPtr References: <94a3289e26898b8f779450bf620d8fef454844c7.1531140049.git.kshcherbatov@tarantool.org> <837b569e130ba06fdf2e6c8cd5554adcb4a66b1a.1531230100.git.kshcherbatov@tarantool.org> From: Vladislav Shpilevoy Message-ID: <97581354-b0b2-44d3-fe16-4c2649271b42@tarantool.org> Date: Tue, 10 Jul 2018 17:59:14 +0300 MIME-Version: 1.0 In-Reply-To: <837b569e130ba06fdf2e6c8cd5554adcb4a66b1a.1531230100.git.kshcherbatov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: Kirill Shcherbatov , tarantool-patches@freelists.org Thanks for finishing the patch! I have force pushed more deletions on the branch. On 10/07/2018 16:45, Kirill Shcherbatov wrote: > From: Vladislav Shpilevoy > > This opcode was used when Vdbe had to store key_def in P4 for > OP_OpenRead/Write, so P4 was occupied and OP_LoadPtr was used to > store space pointer in another opcode. But now P4 is free for > OpenRead/Write and space pointer can be stored here. > > Alongside, some useless key_def duplications are removed. > --- > src/box/sql/analyze.c | 8 ++------ > src/box/sql/build.c | 20 ++++++-------------- > src/box/sql/delete.c | 16 ++-------------- > src/box/sql/insert.c | 18 ++++-------------- > src/box/sql/pragma.c | 15 +++++++++++---- > src/box/sql/vdbe.c | 41 ++++++----------------------------------- > 6 files changed, 31 insertions(+), 87 deletions(-) >