Tarantool development patches archive
 help / color / mirror / Atom feed
From: Oleg Koshovetc <okoshovetc@tarantool.org>
To: Alexander Tikhonov <avtikhon@tarantool.org>, tsafin@tarantool.org
Cc: tarantool-patches@dev.tarantool.org
Subject: [Tarantool-patches] [PATCH] tpch: use normal perf image instead of patched one
Date: Tue, 22 Dec 2020 02:20:37 +0300	[thread overview]
Message-ID: <97201353-fc4d-df72-e92c-261cc76107fc@tarantool.org> (raw)

TPCH benchmark used to be launched with numerous patches applied
to tarantool's source code. Not only it does not bench actual
tarantool, it also adds extra complications in benchmarking process.
Recently we got pipeline failed only because of tpch benchmark as it
would fail to launch because it failed to apply all of the needed
patches. Instead of fixing the patches we'd better get rid of that
patching in the first place.
---
  .gitlab-ci.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index 208ab24..935a27b 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -328,7 +328,7 @@ perf_tpch:
    <<: *perf_docker_test_definition
    tags:
      - docker_sh2_perf
-  image: ${IMAGE_PERF_BUILT}_tpch
+  image: ${IMAGE_PERF_BUILT}
    variables:
      <<: *perf_vars_definition
      BENCH: 'tpch'
-- 
2.7.4

             reply	other threads:[~2020-12-21 23:21 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-21 23:20 Oleg Koshovetc [this message]
2020-12-22  9:41 ` Timur Safin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=97201353-fc4d-df72-e92c-261cc76107fc@tarantool.org \
    --to=okoshovetc@tarantool.org \
    --cc=avtikhon@tarantool.org \
    --cc=tarantool-patches@dev.tarantool.org \
    --cc=tsafin@tarantool.org \
    --subject='Re: [Tarantool-patches] [PATCH] tpch: use normal perf image instead of patched one' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox