From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9F81224EFE
	for <tarantool-patches@freelists.org>; Tue, 10 Jul 2018 12:52:41 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id Raafi-776tHX for <tarantool-patches@freelists.org>;
	Tue, 10 Jul 2018 12:52:41 -0400 (EDT)
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 5FCF924D11
	for <tarantool-patches@freelists.org>; Tue, 10 Jul 2018 12:52:41 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH v1 1/1] sql: refactor
 vdbe_emit_open_cursor calls
References: <94a3289e26898b8f779450bf620d8fef454844c7.1531140049.git.kshcherbatov@tarantool.org>
 <96598d88-35f2-3075-6f90-f2efecd2f0cd@tarantool.org>
 <eb09b1c3-ffba-c392-aecf-d9b215bf04b0@tarantool.org>
 <665e7af1-3a3c-ed51-e9e8-097811a4a7a6@tarantool.org>
 <15e20c40-fc3d-0b1d-271c-5dfaa76d6dd7@tarantool.org>
 <512e60bd-1886-56c3-2d30-e8171e1c0fa1@tarantool.org>
 <4ebd4fc9-6ab9-13bc-6cbe-2f42a5025da3@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <970a2e70-c5f5-fac7-cf7b-2e7f0c6d7cce@tarantool.org>
Date: Tue, 10 Jul 2018 19:52:38 +0300
MIME-Version: 1.0
In-Reply-To: <4ebd4fc9-6ab9-13bc-6cbe-2f42a5025da3@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Kirill Shcherbatov <kshcherbatov@tarantool.org>, tarantool-patches@freelists.org, Nikita Pettik <korablev@tarantool.org>

Thanks for the squash. I have force pushed some comment
style violation fixes.

Nikita, please, do a second review.

On 10/07/2018 19:37, Kirill Shcherbatov wrote:
>> Maybe it is more convenient, but it is not more correct. Your
>> first commit still does not fix the mess with index_id/tnum.
>>
>> Please, squash it into your first commit.
> Ok, I've done this.
>