From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 1EA9FA4E102; Wed, 13 Mar 2024 12:10:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1EA9FA4E102 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1710321033; bh=P6Kg7C9QBRMNa3gnzrtGSixXFlSYv9bhihVRBSgzfxY=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=d4AkJo8BOSOhUsVJ30NWdqNkXnEImhyMszmcPdpbS9tT3TVkXnMuturHYpOgw2Rv+ zqWAM88LGBeXC72gjzf4vDRgIFyClVJZNnJ7zRwh4Jo4SWi1wAvwc2HI+HEH5yfm7M 6YnwJSPYJ38jaPpdfhYUD6TodfJx/uQJfScQfxpQ= Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [95.163.41.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C2E38A4E101 for ; Wed, 13 Mar 2024 12:10:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C2E38A4E101 Received: by smtp55.i.mail.ru with esmtpa (envelope-from ) id 1rkKd3-00000005iBv-3DML; Wed, 13 Mar 2024 12:10:30 +0300 Message-ID: <96ed0966-ef3c-4942-bc6c-06f74c8f0103@tarantool.org> Date: Wed, 13 Mar 2024 12:10:29 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Maxim Kokryashkin References: <93809031fbffd82c29538d652c4418e12db7baaf.1710251441.git.sergeyb@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD987C0EE6E7F0A597D2604A3BCAEBFC93637641474DCE2D7B2182A05F53808504032FA5980A24F95AFD27678DDAA806314CCAE92DE8B1C1E26A99ACAF4C82F3FEB888ABC412A473640 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7DB6A86BDF2D5A895EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063775FF68B4B43662428638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8C6E3D404A382F766A3027E2B98AC0560180B51EE309EDCF0CC7F00164DA146DAFE8445B8C89999728AA50765F790063793270F7220657A0A389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC8B861051D4BA689FCF6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C632EDEA9CD5989A3C0837EA9F3D197644AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3BF1F585E929FBCC0BA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CF27ED053E960B195E1DD303D21008E298D5E8D9A59859A8B6D082881546D9349175ECD9A6C639B01B78DA827A17800CE7742996B5449390BC731C566533BA786AA5CC5B56E945C8DA X-87b9d050: 1 X-C1DE0DAB: 0D63561A33F958A5E0E9CF126098B6145002B1117B3ED6969B09259C44BA3D8DA9DAB4B68AE4D22F823CB91A9FED034534781492E4B8EEAD220496FFA5CD4785BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D3429499E429979B7C7602BB9B483A6DB886870CCC590EEB1AD6914318A0E6B85EEAD840FB014A7BBE61D7E09C32AA3244CC3496AAEF53581242887F5EA2DDCF34426D8B089FA81E312EA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojtv/CB9kl0S060H1WVNJaxQ== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F2588458A99F842DE39FF54957FFD5DAF71AD12C3D83A47CD7B308D33B0BDF147E06E414645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] c: bump version of actions/checkout X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Max, thanks for review! Fixed and force-pushed. On 3/13/24 11:56, Maxim Kokryashkin wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, except for a few nits regarding the commit message. > On Tue, Mar 12, 2024 at 04:51:02PM +0300, Sergey Bronnikov wrote: >> From: Sergey Bronnikov > Patch header contains a typo. > Typo: s/c:/ci:/ Fixed. >> Bump version of actions/checkout to v4. >> Bump fixes an annoying warning that appears in Github WebUI: > Typo: s/in/in the/ Fixed. >> Node.js 16 actions are deprecated. Please update the following actions >> to use Node.js 20: actions/checkout@v3. For more information see: >> https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. > It would be nicer to emphasize the message with | on each line: > | Node.js 16 actions are deprecated. Please update the following actions > | to use Node.js 20: actions/checkout@v3. For more information see: > | https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/. Fixed. > >> --- >> .github/workflows/coverage.yml | 2 +- >> .github/workflows/exotic-builds-testing.yml | 2 +- >> .github/workflows/gnumake-builds-testing.yml | 2 +- >> .github/workflows/lint.yml | 2 +- >> .github/workflows/sanitizers-testing.yml | 2 +- >> .github/workflows/testing.yml | 2 +- >> 6 files changed, 6 insertions(+), 6 deletions(-) >> >