From: Oleg Babin via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>,
tarantool-patches@dev.tarantool.org,
yaroslav.dynnikov@tarantool.org
Subject: Re: [Tarantool-patches] [PATCH 0/2] vshard.storage.buckets_count() bug
Date: Thu, 13 May 2021 23:23:05 +0300 [thread overview]
Message-ID: <96319014-b8b8-b433-d16b-1e66f8413681@tarantool.org> (raw)
In-Reply-To: <cover.1620903962.git.v.shpilevoy@tarantool.org>
Hi! Thanks for patchset. I think links should refer to vshard not
tarantool repo.
See my comments in following e-mails.
On 13.05.2021 14:07, Vladislav Shpilevoy wrote:
> The patchset fixes the issue with buckets_count() returning incorrect values on
> replica nodes due to cache inconsistency.
>
> Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-276-bucket-count-outdated
> Issue: https://github.com/tarantool/tarantool/issues/276
>
> Vladislav Shpilevoy (2):
> test: fix test output on latest Tarantool
> vshard: fix buckets_count() on replicas
>
> test/misc/reconfigure.result | 21 ++++---
> test/misc/reconfigure.test.lua | 13 +++--
> test/router/boot_replica_first.result | 9 ++-
> test/router/boot_replica_first.test.lua | 7 ++-
> test/storage/storage.result | 52 ++++++++++++++++-
> test/storage/storage.test.lua | 22 ++++++-
> vshard/storage/init.lua | 78 ++++++++++++++++++++++---
> 7 files changed, 171 insertions(+), 31 deletions(-)
>
next prev parent reply other threads:[~2021-05-13 20:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-13 11:07 Vladislav Shpilevoy via Tarantool-patches
2021-05-13 11:07 ` [Tarantool-patches] [PATCH 1/2] test: fix test output on latest Tarantool Vladislav Shpilevoy via Tarantool-patches
2021-05-13 20:23 ` Oleg Babin via Tarantool-patches
2021-05-19 21:50 ` Yaroslav Dynnikov via Tarantool-patches
2021-05-21 19:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-21 21:54 ` Yaroslav Dynnikov via Tarantool-patches
2021-05-13 11:07 ` [Tarantool-patches] [PATCH 2/2] vshard: fix buckets_count() on replicas Vladislav Shpilevoy via Tarantool-patches
2021-05-13 20:23 ` Oleg Babin via Tarantool-patches
2021-05-21 19:26 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-24 6:57 ` Oleg Babin via Tarantool-patches
2021-05-19 21:51 ` Yaroslav Dynnikov via Tarantool-patches
2021-05-21 19:30 ` Vladislav Shpilevoy via Tarantool-patches
2021-05-13 20:23 ` Oleg Babin via Tarantool-patches [this message]
2021-05-25 20:43 ` [Tarantool-patches] [PATCH 0/2] vshard.storage.buckets_count() bug Vladislav Shpilevoy via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=96319014-b8b8-b433-d16b-1e66f8413681@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=olegrok@tarantool.org \
--cc=v.shpilevoy@tarantool.org \
--cc=yaroslav.dynnikov@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH 0/2] vshard.storage.buckets_count() bug' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox