From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4F64E4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  5 Apr 2020 22:38:33 +0300 (MSK)
References: <20200403230158.43137-1-sergepetrenko@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <960d1f84-b665-c594-256d-a992a006234a@tarantool.org>
Date: Sun, 5 Apr 2020 21:38:30 +0200
MIME-Version: 1.0
In-Reply-To: <20200403230158.43137-1-sergepetrenko@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] Add const qualifier to
 mp_encode_ext argument
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>, Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

LGTM.

On 04/04/2020 01:01, Serge Petrenko wrote:
> ---
> This is a fix needed in scope of tarantool#4268 (UUID type indices introduction)
> 
> https://github.com/tarantool/tarantool/issues/4268
> https://github.com/tarantool/msgpuck/tree/sp/ext-type-fix
> 
>  msgpuck.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/msgpuck.h b/msgpuck.h
> index 59fc1ee..5dfbbd9 100644
> --- a/msgpuck.h
> +++ b/msgpuck.h
> @@ -570,7 +570,7 @@ mp_encode_extl(char *data, int8_t type, uint32_t len);
>   * \sa mp_encode_strl
>   */
>  MP_PROTO char *
> -mp_encode_ext(char *data, int8_t type, char *str, uint32_t len);
> +mp_encode_ext(char *data, int8_t type, const char *str, uint32_t len);
>  
>  /**
>   * \brief Check that \a cur buffer has enough bytes to decode an ext header.
> @@ -1577,7 +1577,7 @@ mp_encode_extl(char *data, int8_t type, uint32_t len)
>  }
>  
>  MP_IMPL char *
> -mp_encode_ext(char *data, int8_t type, char *str, uint32_t len)
> +mp_encode_ext(char *data, int8_t type, const char *str, uint32_t len)
>  {
>  	data = mp_encode_extl(data, type, len);
>  	memcpy(data, str, len);
>