From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E7B9E6EC55; Fri, 30 Jul 2021 02:40:06 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E7B9E6EC55 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1627602007; bh=FiRtT4VeoxyYp2VJpJ5F3+GS/7Q9P3UP3WPGX6Hyk5k=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=uUTpy6FSAe1Z8cm0jjzZ+c8ShXNrnceE4VHBAIO8AVEaA2YbPJwWTcWBFiRR2xxzQ CcyGFb4vzYfKo74XK2gaccAw6AtPP09vLJZo2G4+QLmszLWIfaYHL4nC9lQcECV/Zc 23bV71W0QkRERDjPjtS4AFXwwqWSnEl4ynGQNa+8= Received: from smtpng3.i.mail.ru (smtpng3.i.mail.ru [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9A4316EC55 for ; Fri, 30 Jul 2021 02:40:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9A4316EC55 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1m9FdD-0004XP-Lt; Fri, 30 Jul 2021 02:40:04 +0300 To: Timur Safin References: Message-ID: <95f9a0a7-e539-f381-aef7-9dd74c50e03e@tarantool.org> Date: Fri, 30 Jul 2021 01:40:02 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD941C43E597735A9C366EE405EC28A2001F8302D8429E0DE58182A05F5380850409ED0AA574350ECC8BC7A4CA4B2ECAFB0968A2498C43E2D6EC92D523E13B19B18 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7CFDA40FA2326E319EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379428F6EA0D091379EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BBCA57AF85F7723F2B6D6DDF78A8D5AD9843A84254EE585C9CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F790063783E00425F71A4181389733CBF5DBD5E9B5C8C57E37DE458B9E9CE733340B9D5F3BBE47FD9DD3FB595F5C1EE8F4F765FC72CEEB2601E22B093A03B725D353964B0B7D0EA88DDEDAC722CA9DD8327EE4930A3850AC1BE2E735D2D576BCF940C736C4224003CC83647689D4C264860C145E X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A213B5FB47DCBC3458834459D11680B505CD2A9081441DFE93494C7B46D813AE16 X-C1DE0DAB: 0D63561A33F958A59F6C7E21544C42BB228B9BFFED61B142BC49FB149B8CBC19D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7517A45118377F5F9E8E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A783A638E01A3CDEDB6FFD4ACA9D0B6DB7DF681B8833B6BC1C4F2DA62C6FEA5ABCD773DE07910DC81D7E09C32AA3244CCB02EFAD2E3203B33EB2F75182E41EF6BBA718C7E6A9E042927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojWBddABnKmoJomUO8BRJsBA== X-Mailru-Sender: 689FA8AB762F7393C37E3C1AEC41BA5DE23D3C7A6BECF7BE8172BBDE6AEBD1C13841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH resend v2 01/11] build: add Christian Hansen c-dt to the build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! On 28.07.2021 12:34, Timur Safin wrote: > * Integrated chansen/c-dt parser as 3rd party module to the > Tarantool cmake build process. > * Points to tsafin/c-dt instead iof original chansen/c-dt to iof -> of. But is it even true? Below I see url = https://github.com/tarantool/c-dt.git not tsafin/c-dt. After build I get in git status this: Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) (commit or discard the untracked or modified content in submodules) modified: third_party/c-dt (modified content, untracked content) It says: modified: Makefile and some untracked files: CMakeFiles/ cmake_install.cmake libcdt.a Why is even Makefile added to the repository if we are using cmake anyway?