From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id D4D6227B9C
	for <tarantool-patches@freelists.org>; Thu, 19 Jul 2018 16:33:24 -0400 (EDT)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id FG751MJ43syf for <tarantool-patches@freelists.org>;
	Thu, 19 Jul 2018 16:33:24 -0400 (EDT)
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 91B74279F4
	for <tarantool-patches@freelists.org>; Thu, 19 Jul 2018 16:33:24 -0400 (EDT)
Subject: [tarantool-patches] Re: [PATCH 1/3] Add test on error during
 reconfigure
References: <cover.1531935745.git.avkhatskevich@tarantool.org>
 <0a1a6702a293c8f86f38d67c92f04da1f6c6a686.1531935745.git.avkhatskevich@tarantool.org>
 <069d5b60-cffa-c24c-06f9-9a9af1af8fcb@tarantool.org>
From: Alex Khatskevich <avkhatskevich@tarantool.org>
Message-ID: <95eccf6c-67fc-d9a5-f3d7-a5b276d1ea88@tarantool.org>
Date: Thu, 19 Jul 2018 23:33:20 +0300
MIME-Version: 1.0
In-Reply-To: <069d5b60-cffa-c24c-06f9-9a9af1af8fcb@tarantool.org>
Content-Type: text/plain; charset="utf-8"; format="flowed"
Content-Transfer-Encoding: 8bit
Content-Language: en-US
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, tarantool-patches@freelists.org


>>   +-- Check that data has at least all fields as an ethalon.
>
> 1. Typo here and in other places: ethalon -> etalon.
Fixed
>
> 2. Please, describe the function in doxygen style since
> it is not a trival one-liner.
Added, however, the comment is bigger than the function...
>> +...
>> +err:match('Error injection:.*')
>
> 3. P l e a s e. Again. Do not use pcall + match. Use
> util.check_error.
Ok. Sorry. It is a very old commit.