From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EA61942EF5C for ; Fri, 26 Jun 2020 00:48:08 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <95439e3c-5c18-8b6e-002a-dc28514a22c1@tarantool.org> Date: Thu, 25 Jun 2020 23:48:06 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 4/8] replication: make sync transactions wait quorum List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko , sergos@tarantool.org, gorcunov@gmail.com Cc: tarantool-patches@dev.tarantool.org I added a commit on top of this one: ==================== Author: Vladislav Shpilevoy Date: Thu Jun 25 23:43:08 2020 +0200 [tosquash] replication: txn_limbo_check_complete() should consider rollback too txn_limbo_check_complete() didn't consider rollback as a completion. Obviously it should. Even though fully functional rollback appears in later commits. diff --git a/src/box/txn_limbo.c b/src/box/txn_limbo.c index bab843c0a..9de91db93 100644 --- a/src/box/txn_limbo.c +++ b/src/box/txn_limbo.c @@ -104,6 +104,8 @@ txn_limbo_assign_lsn(struct txn_limbo *limbo, struct txn_limbo_entry *entry, static bool txn_limbo_check_complete(struct txn_limbo *limbo, struct txn_limbo_entry *entry) { + if (txn_limbo_entry_is_complete(entry)) + return true; struct vclock_iterator iter; vclock_iterator_init(&iter, &limbo->vclock); int ack_count = 0;