From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id F3ECF2F3ED for ; Thu, 16 May 2019 18:46:48 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id q56vMiny3rZq for ; Thu, 16 May 2019 18:46:48 -0400 (EDT) Received: from smtp21.mail.ru (smtp21.mail.ru [94.100.179.250]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3D22D2F3EC for ; Thu, 16 May 2019 18:46:48 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH 09/10] swim: cache decoded payload in the Lua module References: <20190516073604.GH26670@atlas> From: Vladislav Shpilevoy Message-ID: <94bb1610-b507-0e3b-3298-6c7a8333f79f@tarantool.org> Date: Fri, 17 May 2019 01:46:43 +0300 MIME-Version: 1.0 In-Reply-To: <20190516073604.GH26670@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Konstantin Osipov On 16/05/2019 10:36, Konstantin Osipov wrote: > * Vladislav Shpilevoy [19/05/16 09:53]: >> Users of Lua SWIM module likely will use Lua objects as a >> payload. Lua objects are serialized into MessagePack >> automatically, and deserialized back on other instances. But >> deserialization of 1.2Kb payload on each member:payload() >> invocation is quite heavy operation. This commit caches decoded >> payloads to return them again until change. > > The entire stack is OK to push. But the stack has no docbot entry. > Please submit a documentation request with a complete description > of SWIM and the API: it's a complicated topic and one can't expect > the docs team to handle it alone. The request appeared to be so huge, that I decided to paste it in the ticket: https://github.com/tarantool/tarantool/issues/3234#issuecomment-493256667