From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C97CF445321
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 14 Jul 2020 01:59:13 +0300 (MSK)
References: <cover.1591259297.git.sergeyb@tarantool.org>
 <ccfdf69c72fd2364a381f1c89a8025268ac84e89.1591259297.git.sergeyb@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <94773845-a7d3-567f-d59c-bd006ed6d2bc@tarantool.org>
Date: Tue, 14 Jul 2020 00:59:11 +0200
MIME-Version: 1.0
In-Reply-To: <ccfdf69c72fd2364a381f1c89a8025268ac84e89.1591259297.git.sergeyb@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 6/6] Fix luacheck warnings in
 src/box/lua/
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: sergeyb@tarantool.org, tarantool-patches@dev.tarantool.org, imun@tarantool.org
Cc: alexander.turenko@tarantool.org

Thanks for the fixes!

I force pushed the following change:

====================
diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua
index 7256bd0a3..1d3c474d5 100644
--- a/src/box/lua/net_box.lua
+++ b/src/box/lua/net_box.lua
@@ -915,7 +915,7 @@ end
 -- Now it is necessary to have a strong ref to callback somewhere or
 -- it is GC-ed prematurely. We wrap stop() method, stashing the
 -- ref in an upvalue (stop() performance doesn't matter much.)
-local create_transport = function(host, port, user, password, callback, -- luacheck: ignore
+local create_transport = function(host, port, user, password, callback,
                                   connection, greeting)
     local weak_refs = setmetatable({callback = callback}, {__mode = 'v'})
     local function weak_callback(...)

====================

But what I don't understand is why this commit does not close 4681?
What is left?