From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 3263E6FC8F; Fri, 16 Apr 2021 13:56:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 3263E6FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618570603; bh=JtDyQH+TH7sxjGGSV0UfdeJYef3crdaMAfaoJHwdnTM=; h=To:Cc:Date:Subject:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From:Reply-To:From; b=EG0qLEppkLVSsyM8DD10fWZxSkLL8s/Q4KKCiTFvnEZrcDXtMYlGdUhBWkbQDdy4/ Ba91Cu6ncKoseZRcMQDGBQnC5c9jd2s+50yJi7jYLMn24caLyJKYGvJxT/ao5yiejn 8kHnid43jFQiFaGvMkClpmnQzSFbiVS8zLAhsgkY= Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 17B146FC8F for ; Fri, 16 Apr 2021 13:56:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 17B146FC8F Received: by smtpng1.m.smailru.net with esmtpa (envelope-from ) id 1lXM9R-00041F-8F; Fri, 16 Apr 2021 13:56:41 +0300 To: v.shpilevoy@tarantool.org Cc: tarantool-patches@dev.tarantool.org Date: Fri, 16 Apr 2021 13:56:40 +0300 Message-Id: <93f9710b8ee9b17b023b18dfa09da7e1d566340b.1618570487.git.imeevma@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E74800BD71C2E2CF43DDE8CBA234A641A13D4182A05F538085040DC72D485D94B78A02146C062BA49301686F42FB85AD2149A68CF80FEECC27C7A X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE76D34FAA3D8B31588C2099A533E45F2D0395957E7521B51C2CFCAF695D4D8E9FCEA1F7E6F0F101C6778DA827A17800CE74FC7AD0AD96C1577EA1F7E6F0F101C67CDEEF6D7F21E0D1D9295C2E9FA3191EE1B59CA4C82EFA658A2CDD8CE8FAA3C09AAC5F48771D340A1F6B57BC7E64490618DEB871D839B73339E8FC8737B5C224936DA1BED736F9328CC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C0ECC8AC47CD0EDEFF8941B15DA834481F9449624AB7ADAF372E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16B6D8C47C27EEC5E9FB5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975CBF1196BB3248DD4B23AD6EB0CE9DE43314A3C902277AC0E99C2B6934AE262D3EE7EAB7254005DCEDF7BC592D836A292C1E0A4E2319210D9B64D260DF9561598F01A9E91200F654B02DA3D96DA0CEF5C48E8E86DC7131B365E7726E8460B7C23C X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34EA882B598A2098119E4AB8334489695745D356DE9DC12440E193F1552330AFF9C707B2FAEDEB2F241D7E09C32AA3244C8AB8D4C0EBE04A2C2C995970AC6D733735DA7DC5AF9B58C0729B2BEF169E0186 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3S6P1v0GIqRPCNbQ0+N03Q== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638229265A9BA4D3650938D5B73AD1B91A18983D72C36FC87018B9F80AB2734326CD2FB559BB5D741EB96352A0ABBE4FDA4210A04DAD6CC59E33667EA787935ED9F1B X-Mras: Ok Subject: [Tarantool-patches] [PATCH 1/1] Add test and changelog for issue gh-5890 X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mergen Imeev via Tarantool-patches Reply-To: imeevma@tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" --- ...fix-wrong-result-on-select-with-groupby.md | 4 +++ ...gh-5890-wrong-select-with-groupby.test.lua | 28 +++++++++++++++++++ 2 files changed, 32 insertions(+) create mode 100644 changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md create mode 100755 test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua diff --git a/changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md b/changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md new file mode 100644 index 000000000..1ed39ccce --- /dev/null +++ b/changelogs/unreleased/fix-wrong-result-on-select-with-groupby.md @@ -0,0 +1,4 @@ +## bugfix/sql + +* Fix wrong result of SELECT with GROUP BY in case one of selected values is + VARBINARY, which is not directly obtained from a space (gh-5890). diff --git a/test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua b/test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua new file mode 100755 index 000000000..2b7e19862 --- /dev/null +++ b/test/sql-tap/gh-5890-wrong-select-with-groupby.test.lua @@ -0,0 +1,28 @@ +#!/usr/bin/env tarantool +local test = require("sqltester") +test:plan(2) + +-- +-- Make sure the SELECT result does not change if GROUP BY is used in case one of +-- selected values is also used in GROUP BY and is a VARBINARY that is not +-- directly received from space. +-- +test:do_execsql_test( + "gh-5890-1", + [[ + CREATE TABLE t(i INT PRIMARY KEY, v VARBINARY); + INSERT INTO t VALUES(1, x'6178'), (2, x'6278'), (3, x'6379'); + SELECT count(*), substr(v,2,1) AS m FROM t GROUP BY m; + ]], { + 2, 'x', 1, 'y' + }) + +test:do_execsql_test( + "gh-5890-2", + [[ + SELECT count(*), v || v AS m FROM t GROUP BY m; + ]], { + 1, 'axax', 1, 'bxbx', 1, 'cycy' + }) + +test:finish_test() -- 2.25.1