From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] raft: make sure the voking mask is wide enough
Date: Mon, 2 Nov 2020 23:28:54 +0100 [thread overview]
Message-ID: <93dac5d3-0711-7110-cd0d-11aa8022511b@tarantool.org> (raw)
In-Reply-To: <20201028181352.260915-1-gorcunov@gmail.com>
Thanks for the patch!
It would be better to replace uint32_t with vclock_map_t
for vote_mask member. I didn't think of that type when implemented
the mask, but it seems to fit here better than a static assertion
and uint32_t.
prev parent reply other threads:[~2020-11-02 22:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 18:13 Cyrill Gorcunov
2020-10-28 18:56 ` [Tarantool-patches] [PATCH v2] raft: make sure the voting " Cyrill Gorcunov
2020-10-30 7:33 ` Serge Petrenko
2020-10-30 8:30 ` [Tarantool-patches] [PATCH v3] raft: make sure the voking " Cyrill Gorcunov
2020-10-30 8:39 ` Serge Petrenko
2020-11-02 22:04 ` [Tarantool-patches] " Vladislav Shpilevoy
2020-11-02 22:17 ` Cyrill Gorcunov
2020-11-02 22:28 ` Vladislav Shpilevoy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=93dac5d3-0711-7110-cd0d-11aa8022511b@tarantool.org \
--to=v.shpilevoy@tarantool.org \
--cc=gorcunov@gmail.com \
--cc=tarantool-patches@dev.tarantool.org \
--subject='Re: [Tarantool-patches] raft: make sure the voking mask is wide enough' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox