From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 9590024780 for ; Tue, 30 Jul 2019 09:43:09 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id oQWEn6aRoXvD for ; Tue, 30 Jul 2019 09:43:09 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E0AC722C04 for ; Tue, 30 Jul 2019 09:43:08 -0400 (EDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.11\)) Subject: [tarantool-patches] Re: [PATCH 3/5] sql: use 'varbinary' as a name of type instead of 'blob' From: "n.pettik" In-Reply-To: <027525d2-deed-d70b-b06b-3e49bf92d7c3@tarantool.org> Date: Tue, 30 Jul 2019 16:43:06 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <93CF3B4E-A159-491A-8253-F3F5D9FBF875@tarantool.org> References: <2e655514-0fec-8baf-20a8-d49e5586b047@tarantool.org> <027525d2-deed-d70b-b06b-3e49bf92d7c3@tarantool.org> Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy >>> func.c :540, :1185, :1254, :1753 >>> vdbeapi.c:283, :382, :1061 >>> vdbemem.c:996, :1022 >>> vdbeaux.c:1192 >>=20 >> All these usages are in form of: >> "string or blob is too big=E2=80=9D >>=20 >> I think that blob is a good name for entity of varbinary >> type. Another possible names are =E2=80=9Cbinary sequence=E2=80=9D, >> =E2=80=9Cbinary data=E2=80=9D or =E2=80=9Cbinary string=E2=80=9D. The = latter variant is used >> in the ANSI specification. Now I=E2=80=99ve changed to =E2=80=9Cbinary = string=E2=80=9D, >> but if you can suggest better name, let=E2=80=99s discuss it. >=20 > No, I don't mind any name. I saw, that in the commit message > you said >=20 > "Thus, let's fix all visible to user messages using 'varbinary' > name of type instead of 'blob'." >=20 > And I noticed, that there are still visible messages mentioning blob. > You can keep blob, or rename, or anything. I=E2=80=99m okay with "binary string=E2=80=9D as well, so let=E2=80=99s = keep it.