From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <tarantool-patches-bounce@freelists.org>
Received: from localhost (localhost [127.0.0.1])
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 37114217BA
	for <tarantool-patches@freelists.org>; Sat, 29 Dec 2018 08:35:05 -0500 (EST)
Received: from turing.freelists.org ([127.0.0.1])
	by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id CS2DltAmwMdU for <tarantool-patches@freelists.org>;
	Sat, 29 Dec 2018 08:35:05 -0500 (EST)
Received: from smtp35.i.mail.ru (smtp35.i.mail.ru [94.100.177.95])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id E02BB1FF5A
	for <tarantool-patches@freelists.org>; Sat, 29 Dec 2018 08:35:04 -0500 (EST)
Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\))
Subject: [tarantool-patches] Re: [PATCH v2 5/5] sql: do not use
 OP_Delete+OP_Insert for UPDATES
From: "n.pettik" <korablev@tarantool.org>
In-Reply-To: <855d85cccdd7e33aa4b49988c5165512d5fa94ad.1546079994.git.kshcherbatov@tarantool.org>
Date: Sat, 29 Dec 2018 15:35:00 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <92C91EEB-6934-40C4-96C2-46487F97A697@tarantool.org>
References: <cover.1546079994.git.kshcherbatov@tarantool.org>
 <855d85cccdd7e33aa4b49988c5165512d5fa94ad.1546079994.git.kshcherbatov@tarantool.org>
Sender: tarantool-patches-bounce@freelists.org
Errors-to: tarantool-patches-bounce@freelists.org
Reply-To: tarantool-patches@freelists.org
List-help: <mailto:ecartis@freelists.org?Subject=help>
List-unsubscribe: <tarantool-patches-request@freelists.org?Subject=unsubscribe>
List-software: Ecartis version 1.0.0
List-Id: tarantool-patches <tarantool-patches.freelists.org>
List-subscribe: <tarantool-patches-request@freelists.org?Subject=subscribe>
List-owner: <mailto:>
List-post: <mailto:tarantool-patches@freelists.org>
List-archive: <http://www.freelists.org/archives/tarantool-patches>
To: tarantool-patches@freelists.org
Cc: Kirill Shcherbatov <kshcherbatov@tarantool.org>


>=20
> +/** Callback to forward and error from mpstream methods. */
> +static inline void
> +mpstream_encode_error(void *error_ctx)
> +{
> +	*(bool *)error_ctx =3D true;
> +}

Is this artefact after previous patch?

> +/**
> + * Perform encoding memory variable to stream.
> + * @param stream Initialized mpstream encoder object.
> + * @param var Vdbe memory variable to encode with stream.
> + */
> +void
> +mpstream_encode_vdbe_mem(struct mpstream *stream, struct Mem *var);
> +

The same question.

The rest is Ok now.

I didn=E2=80=99t carefully check test fixes tho, only looked through, =
since they
consist of monotonic changes, but I believe you did it :)