From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EFBBD42EF5C for ; Wed, 24 Jun 2020 01:39:20 +0300 (MSK) From: Vladislav Shpilevoy Date: Wed, 24 Jun 2020 00:39:19 +0200 Message-Id: <923962ad34ef999c7e819b7a84891e204de23646.1592951940.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 1/1] [tosquash] test: add a test for sync heartbeats List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org, sergepetrenko@tarantool.org Should be squashed into the commit closing 5100. --- Branch: http://github.com/tarantool/tarantool/tree/gh-4842-sync-replication Issue: https://github.com/tarantool/tarantool/issues/4842 .../sync_replication_sanity.result | 50 +++++++++++++++++++ .../sync_replication_sanity.test.lua | 22 ++++++++ 2 files changed, 72 insertions(+) diff --git a/test/replication/sync_replication_sanity.result b/test/replication/sync_replication_sanity.result index 4b9823d77..a0591dcf3 100644 --- a/test/replication/sync_replication_sanity.result +++ b/test/replication/sync_replication_sanity.result @@ -178,6 +178,53 @@ box.space.sync:select{} | - [3] | ... +-- +-- gh-5100: replica should send ACKs for sync transactions after +-- WAL write immediately, not waiting for replication timeout or +-- a CONFIRM. +-- +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} + | --- + | ... +test_run:switch('replica') + | --- + | - true + | ... +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} + | --- + | ... +test_run:switch('default') + | --- + | - true + | ... +-- Commit something non-sync. So as applier writer fiber would +-- flush the pending heartbeat and go to sleep with the new huge +-- replication timeout. +s = box.schema.create_space('test') + | --- + | ... +pk = s:create_index('pk') + | --- + | ... +s:replace{1} + | --- + | - [1] + | ... +-- Now commit something sync. It should return immediately even +-- though the replication timeout is huge. +box.space.sync:replace{4} + | --- + | - [4] + | ... +test_run:switch('replica') + | --- + | - true + | ... +box.space.sync:select{4} + | --- + | - - [4] + | ... + -- Cleanup. test_run:cmd('switch default') | --- @@ -195,6 +242,9 @@ test_run:cmd('delete server replica') | --- | - true | ... +box.space.test:drop() + | --- + | ... box.space.sync:drop() | --- | ... diff --git a/test/replication/sync_replication_sanity.test.lua b/test/replication/sync_replication_sanity.test.lua index 8715a4600..f769804ca 100644 --- a/test/replication/sync_replication_sanity.test.lua +++ b/test/replication/sync_replication_sanity.test.lua @@ -71,11 +71,33 @@ box.space.sync:select{} test_run:cmd('restart server replica') box.space.sync:select{} +-- +-- gh-5100: replica should send ACKs for sync transactions after +-- WAL write immediately, not waiting for replication timeout or +-- a CONFIRM. +-- +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} +test_run:switch('replica') +box.cfg{replication_timeout = 1000, replication_synchro_timeout = 1000} +test_run:switch('default') +-- Commit something non-sync. So as applier writer fiber would +-- flush the pending heartbeat and go to sleep with the new huge +-- replication timeout. +s = box.schema.create_space('test') +pk = s:create_index('pk') +s:replace{1} +-- Now commit something sync. It should return immediately even +-- though the replication timeout is huge. +box.space.sync:replace{4} +test_run:switch('replica') +box.space.sync:select{4} + -- Cleanup. test_run:cmd('switch default') box.cfg{replication_synchro_quorum=quorum, replication_synchro_timeout=timeout} test_run:cmd('stop server replica') test_run:cmd('delete server replica') +box.space.test:drop() box.space.sync:drop() box.schema.user.revoke('guest', 'replication') -- 2.21.1 (Apple Git-122.3)