From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9F98E4696C0 for ; Fri, 29 Nov 2019 01:41:55 +0300 (MSK) References: <659c12232934c069ae8d71ed1e2bc8115d36f6e0.1574846892.git.korablev@tarantool.org> From: Vladislav Shpilevoy Message-ID: <9229bfa1-f516-5072-320b-9ab197a03da0@tarantool.org> Date: Thu, 28 Nov 2019 23:41:52 +0100 MIME-Version: 1.0 In-Reply-To: <659c12232934c069ae8d71ed1e2bc8115d36f6e0.1574846892.git.korablev@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH 5/6] sql: extend result set with autoincrement List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Nikita Pettik , tarantool-patches@dev.tarantool.org Thanks for the patch! On 27/11/2019 13:15, Nikita Pettik wrote: > If result set contains column which features attached sequence > (AUTOINCREMENT in terms of SQL) then meta-information will contain > corresponding field ('autoicrement' : boolean) in response. 1. Please, lets name all booleans values with 'is_' prefix: is_autoincrement, IPROTO_FIELD_IS_AUTOINCREMENT. > diff --git a/src/box/sql/vdbeInt.h b/src/box/sql/vdbeInt.h > index 0e54e42a5..63afb8777 100644 > --- a/src/box/sql/vdbeInt.h > +++ b/src/box/sql/vdbeInt.h > @@ -355,6 +355,8 @@ struct sql_column_metadata { > * columns: all other expressions are nullable by default. > */ > int8_t nullable : 2; > + /** True if column features autoincrement property. */ > + int8_t actoincrement : 1; 2. Lets make it bool, and name is_autoincrement. > }; > > /*