From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp55.i.mail.ru (smtp55.i.mail.ru [217.69.128.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 2FF9F46970F for ; Thu, 28 Nov 2019 02:09:12 +0300 (MSK) From: Vladislav Shpilevoy References: <12ed4be2e7e433fdca58a43fc3b937eb9a54f52f.1573121685.git.imeevma@gmail.com> <9fe3bd05-17de-e878-4395-4d15cf2f0b38@tarantool.org> <20191107141209.GA10466@tarantool.org> <93979a0b-1708-1125-1142-74f22734b088@tarantool.org> <20191115140609.GA15961@tarantool.org> <3d76e64a-cd03-1bf1-5830-0d0b142a5e27@tarantool.org> <194ae7ab-61bc-797a-527e-81704ade2545@tarantool.org> <20191127103309.GA16066@tarantool.org> <3062f665-907c-7860-bbbd-430c89b6a66e@tarantool.org> <1695bfaa-b250-ad14-848d-1a55fd13508c@tarantool.org> Message-ID: <92073cf2-5be6-e153-87b2-93a7c3ddba64@tarantool.org> Date: Thu, 28 Nov 2019 00:09:10 +0100 MIME-Version: 1.0 In-Reply-To: <1695bfaa-b250-ad14-848d-1a55fd13508c@tarantool.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v3 3/5] sql: introduce SET statement List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Mergen Imeev Cc: tarantool-patches@dev.tarantool.org On 28/11/2019 00:07, Vladislav Shpilevoy wrote: > No, stop. It is not LGTM. > > 1) Why on the branch I see a commit > > "sql: refactor PRAGMA-related code" Ok, I see it in v5 thread. I am fucked. I have 50 emails on review. Sorry.