From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 122632D7E7 for ; Mon, 29 Apr 2019 11:05:21 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gRWsshB18pFw for ; Mon, 29 Apr 2019 11:05:21 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id C49E92D7CC for ; Mon, 29 Apr 2019 11:05:20 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 2/3] sql: rework diag_set() in OP_Halt References: <79e3d0e51a64bf35cf5b505d2541996f60b02b8c.1555072183.git.imeevma@gmail.com> <28C698E1-979F-4148-942E-38DCAE4AE0DD@tarantool.org> <20190426074808.GC23413@tarantool.org> <353E4E8B-DA71-4F64-8A61-4E89151E7B5B@tarantool.org> From: Imeev Mergen Message-ID: <912f6a63-c955-f58b-22d6-f0128e05163a@tarantool.org> Date: Mon, 29 Apr 2019 18:05:17 +0300 MIME-Version: 1.0 In-Reply-To: <353E4E8B-DA71-4F64-8A61-4E89151E7B5B@tarantool.org> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: "n.pettik" , tarantool-patches@freelists.org Hi! Thank you for review. Next time I will send this patch as part of "diag_set() in vdbe" patch-set. On 4/29/19 2:35 AM, n.pettik wrote: > >> On 26 Apr 2019, at 10:48, Mergen Imeev wrote: >> >> On Mon, Apr 15, 2019 at 06:21:55PM +0300, n.pettik wrote: >>> >>>> On 12 Apr 2019, at 15:34, imeevma@tarantool.org wrote: >>>> >>>> Before this patch it was possible to have an error code with wrong >>>> error description. This patch fixes it. >>> Could you please supply this statement with an example(s)? >>> >> I changed the commit message. In fact, I found an error that had >> no error code at all: > Could you fix that? Already done in this commit. > >> ... >> >> tarantool> box.execute('select 1 limit true') >> --- >> - error: Only positive integers are allowed in the LIMIT clause >> ... >> >> tarantool> box.error.last().code >> --- >> - 0 >> ... >> >> >> I still think it would be better to use P3 instead of P5. > Does it matter? This will allow using only one statement instead of two. The error described above was caused by the lack of the second statement. After this patch, this case is less likely, because if there is no second operator, an “unknown error” will be shown.