From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1CB204696C5
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  3 Apr 2020 01:20:38 +0300 (MSK)
References: <cb1010c1497f1d134e576b5bbbd6c1d0520ff7f4.1585756172.git.korablev@tarantool.org>
 <2d0316df-dda7-6438-d8cb-c7fd6290d830@tarantool.org>
 <20200402141545.GB30923@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <91132370-b7d2-cb08-7a42-3f97b29da858@tarantool.org>
Date: Fri, 3 Apr 2020 00:20:36 +0200
MIME-Version: 1.0
In-Reply-To: <20200402141545.GB30923@tarantool.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH] box: always promote error created
	via box.error() to diag
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for the fixes!

> commit 28c43bbdb82f78b7a2d19e55de181ddb7d370497
> Author: Nikita Pettik <korablev@tarantool.org>
> Date:   Wed Apr 1 16:32:22 2020 +0300
> 
>     box: always promote error created via box.error() to diag
>     
>     This patch makes box.error() always promote error to the diagnostic
>     area despite of passed arguments.
>     
>     Closes #4829
>     
>     @TarantoolBot document
>     Title: always promote error created via box.error() to diag
>     
>     box.error() is able to accept two types of argument: either pair of code
>     + reason (box.error{code = 555, reason = 'Arbitrary message'}) or error

This '+' in the beginning of a line turns into a bullet point in
github markdown. Check 'Preview' when try to create a ticket. You
can escape it using \+, or move 'code' word on the same line
before +.