On 4/29/19 2:35 AM, n.pettik wrote: > > >> On 26 Apr 2019, at 10:37, Mergen Imeev > > wrote: >> >> On Mon, Apr 15, 2019 at 06:19:34PM +0300, n.pettik wrote: >>> 'make ... the only errcode of OP_Halt’ -> >>> make … be the only ... >>> >>>> On 12 Apr 2019, at 15:34,imeevma@tarantool.org >>>> wrote: >>>> >>>> After this patch, the only error code that the OP_Halt opcode >>>> will work with is SQL_TARANTOOL_ERROR. >>> >>> So, why do we need it at all now? Let’s use simple flag >>> is_aborted like in parser. >>> >> I could not do it now. >> I think we will do this when rc is one of >> SQL_OK, SQL_ROW, SQL_DONE or SQL_TARANTOOL_ERROR. This will be in >> the next patch-set. > > That’s OK, but still don’t understand what prevents you from > doing it right now..BTW, I don’t see corresponding patch in the > patch-set you’ve already sent (next one). The rc field is used to return some information from functions that return an error code in case something went wrong. In this regard, I think that we can completely remove this field instead of replacing it with is_aborted. However, after I tried to do this, I found that at the moment it had too many connections with the code. I'm not quite sure that it will be safe to remove the rc field right now. I would suggest removing some unused modules and reworking the memory system into SQL before we remove the rc field from the Vdbe structure.