From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 24ECB4696C3
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 16 Apr 2020 03:02:37 +0300 (MSK)
References: <cover.1586505741.git.lvasiliev@tarantool.org>
 <36240df4750932601c23b3b3fe4fe11e1034dfb1.1586505741.git.lvasiliev@tarantool.org>
 <dade5463-268a-e00b-4515-5ae0858c1ba4@tarantool.org>
 <2a1c9210-d6d7-fa5f-7906-f6623139a28c@tarantool.org>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <90d516c0-c6bc-9cfe-06a6-80b89a4969f4@tarantool.org>
Date: Thu, 16 Apr 2020 02:02:35 +0200
MIME-Version: 1.0
In-Reply-To: <2a1c9210-d6d7-fa5f-7906-f6623139a28c@tarantool.org>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [Tarantool-patches] [PATCH v2 3/5] error: Increase the number
 of fields transmitted through IPROTO
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: lvasiliev <lvasiliev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Thanks for the fixes!

>>> diff --git a/src/box/lua/net_box.lua b/src/box/lua/net_box.lua
>>> index 07fa54c..1e0cd7a 100644
>>> --- a/src/box/lua/net_box.lua
>>> +++ b/src/box/lua/net_box.lua
>>> @@ -287,7 +289,24 @@ local function create_transport(host, port, user, password, callback,
>>>                       local error = self.response[i]
>>>                       local code = error[IPROTO_ERROR_CODE]
>>>                       local msg = error[IPROTO_ERROR_MESSAGE]
>>> -                    local new_err = box.error.new({code = code, reason = msg})
>>> +                    local custom_type = error[IPROTO_ERROR_CUSTOM_TYPE]
>>> +                    local traceback = error[IPROTO_ERROR_TRACEBACK]
> After we decided don't concatenate the traceback, I decided that it would be inconsistent to transmit the traceback in the case of "throw" over the network, since when creating a new error, the "trace" is set new and it always has been. Furthermore, an error can change the type. So, I delete IPROTO_ERROR_TRACEBACK.If you consider it wrong decision, I can return IPROTO_ERROR_TRACEBACK.

I am ok with that. As I said, traceback is not really a kind of
critical and stable feature anyway.