From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 200506B967; Wed, 14 Apr 2021 02:06:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 200506B967 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618355216; bh=E0ESoBfcMAMiUwKzP9JQVKkmvpq+twkwycPLqigXwCw=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ClTUHAQcfUX9TDfWE+qr8FKB+M+6Fx/eKC8qpSpfCidlFLxRDgMjUy+x500X4/Bpb OaPEEGWQb5vYHj6Kk3BbjL/hEpowjSmXo82O3Jia4QZrfNOr275F1pfmWPgTaw2kiT 0KDjkJBwFmrGVW0wPqBvq/6AcIjHkhu76ZBH9s9Y= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E9D536B962 for ; Wed, 14 Apr 2021 02:06:54 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E9D536B962 Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lWS7S-00050i-3e; Wed, 14 Apr 2021 02:06:54 +0300 To: imeevma@tarantool.org, tsafin@tarantool.org Cc: tarantool-patches@dev.tarantool.org References: <326fac6c97ae260b32be9987e48e3381c600ba9c.1618000037.git.imeevma@gmail.com> Message-ID: <90cf544d-5188-ed34-face-15c231de09d1@tarantool.org> Date: Wed, 14 Apr 2021 01:06:53 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <326fac6c97ae260b32be9987e48e3381c600ba9c.1618000037.git.imeevma@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480B1C8842CE613979723F2FB4628545A35182A05F538085040CA2C359D2BE88352FF04CF77EC1BE81019271E53A42D8FE5F22000001DA75C57 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7059B0D8AC717918AEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006378B49D47CE295E66E8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2D606F478875AE0995277E3CF311CC8AFBE5E7F44427E1A0ED2E47CDBA5A96583C09775C1D3CA48CFCA5A41EBD8A3A0199FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C317B107DEF921CE79117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B3DEB35D4F4140487EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A5DADFDC50DEDB28A290272D1B7E46E9220A6A9DF785F5F362D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D349F4E6BC39AAD02BB82F2338F8295865134040721DC6A6B32C8DE6B0300D4A0529DD3869484ABADAA1D7E09C32AA3244C43D3CCD8B8F3CDD35B53D03E574B0E45A995755A1445935EFACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnA7/qPBUIXHB7ni18S1qNw== X-Mailru-Sender: 689FA8AB762F73936BC43F508A063822BCA45A95EA15F400F143E9220A8CE1D43841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v5 51/52] sql: introduce mem_get_bytes_len() X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Good job on the patch! > diff --git a/src/box/sql/func.c b/src/box/sql/func.c > index 2896a5c31..746bda0f4 100644 > --- a/src/box/sql/func.c > +++ b/src/box/sql/func.c > @@ -65,6 +65,14 @@ mem_as_bin(struct Mem *mem) > return s; > } > > +static int > +mem_get_length(struct Mem *mem) > +{ > + uint32_t len; > + mem_get_bytes_len(mem, &len); mem_get_bytes_len() is never used except here. I suggest you to rename it to mem_len(), drop mem_get_length(), and use mem_len() everywhere. Since you ignore the error always, it probably must has 'unsafe' suffix to emphasize it is broken.