From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id B54B06EC44; Sun, 15 Nov 2026 18:12:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B54B06EC44 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1794755578; bh=L5r9sKYX6vLkoBtOL/iTK9w9LTAKcH6sJbLnwxdr9lo=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ptAoBmCBI0AxQbSMAqDaL/IXiWvd7T+VQ9ekngN9DqlVUmTYxppIWfcUuPbCb/wOo Kd6mlF3/YxY4DrWkXBeqTavvxDrZXGIfcwyV+t49WKvYXDNoroLpAp62GYFcJcGMjw 7/5XrCcAbsrOtBJ5NEyl1T+CT7GMEN6VfY9w0UxI= Received: from send60.i.mail.ru (send60.i.mail.ru [89.221.237.155]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B662C6EC44 for ; Sun, 15 Nov 2026 18:12:56 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B662C6EC44 Received: by exim-smtp-f7c4f5855-lg5tc with esmtpa (envelope-from ) id 1xSbuZ-000000006BM-28fu; Sun, 15 Nov 2026 18:12:55 +0300 Message-ID: <908b58ba-90b6-4f1d-9737-86432857f39d@tarantool.org> Date: Sun, 15 Nov 2026 18:12:55 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Bronnikov , Sergey Kaplun References: Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD93F98A09C3FD4AFA251891063016904FEE58817C70B496CA5182A05F538085040DA6A8188399DF4593DE06ABAFEAF6705F7B5FD2FBD8930E225684A8DAA9E98A7C77A06E522078DAD X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE789066434B85BF7C7EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375660DEDE30684C59E5BEBEA98B74ACD0559980153640F42796BE32029BE941483B3389733CBF5DBD5E9D5E8D9A59859A8B6E232F00D8D26902CA471835C12D1D977C4224003CC836476EB9C41850244470149FD398EE364050F140C956E756FBB7A32F3B5D5B27460C0B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B8D940F9BB5DEEEE475ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5A457D135E9CF05A55002B1117B3ED696456A4D8125009AE9C81EEE05487B0209823CB91A9FED034534781492E4B8EEADF035437B6AEB70F4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D659B8FE8FCD6E676C15258F2DF2F00F35CF0742FB974CCAE41596E5AA374945828CC4C2072B27C46009B8341EE9D5BE9A0A8220BD5D1698DDF1C2AEAC4CF338976031DE901C356016999350E1BD188BD56E4C41F94D744909CEEF9E35A692215F79327F81E6EEE0AEB67A0F9F91F029B6AF33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWCX4DEGjfHf5m5/lFOSIJYM= X-Mailru-Sender: 015BA6FC0EFA223A63A6570A1A03128562880ADC3FD6B624B951B70A5BD4BD8EA9141B102A3F8BAE114698FBA59F30EEE62B12C1FE0372A178274A4A9E9E44FD2A114EDA040D8818F01FF9DF31C397A372D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/3] sysprof: fix crash on a failed stream flush X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Evgeniy Temirgaleev via Tarantool-patches Reply-To: Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! It's an addition to my first letter: I saw the default implementation of the writer in the lib_misc.c: ``` /* ** Default buffer writer function. ** Just call write to the corresponding descriptor. */ static size_t buffer_writer_default(const void **buf_addr, size_t len, void *opt) ``` It implements the writer definition ``` /* ** Buffer writer which is called on the buffer flush. ** Should return amount of written bytes on success or zero in case of error. ** *data should contain a buffer of at least the initial size. ** If *data == NULL stream stops. */ typedef size_t (*lj_wbuf_writer)(const void **data, size_t len, void *opt); ``` in a way, where unrecoverable error follows with stream stop. It's a more strong postcondition* ('res == 0 -> errno != 0 && *data == NULL') (1) than the definition requires ('res == 0 -> errno != 0 || *data == NULL') (2). But all existing LuaJIT code including your lj_wbuf.c patch actually implies (1), not (2). I think, it's an option: leave your patch as is with additional fix of the lj_wbuf_writer requirements to (1) with removing unused STREAM_ERRIO flag. -- (*) Actually buffer_writer_default() implements postcondition (1'): (1') ('res < len -> errno != 0 && *data == NULL') This must be fixed also (`return 0` instead of `return write_total`, lib_misc.c, line 123). --- First letter quoting: On 11/2/26 4:12 PM, Sergey Bronnikov wrote: > From: Sergey Bronnikov > Now `wbuf_reserve()` reports whether the stream was stopped during > the flush. All the write functions skip writing in this case, > including the loop pumping a large payload through the buffer. > > Fixes tarantool/tarantool#11620 > --- > src/lj_wbuf.c | 20 +- > @@ -72,7 +80,8 @@ void LJ_FASTCALL lj_wbuf_addu64(struct lj_wbuf *buf, uint64_t n) > { > if (LJ_UNLIKELY(lj_wbuf_test_flag(buf, STREAM_STOP))) > return; > - wbuf_reserve(buf, LEB128_U64_MAXSIZE); > + if (LJ_UNLIKELY(!wbuf_reserve(buf, LEB128_U64_MAXSIZE))) > + return; "Is it OK, if the writer report an error only, the buffer content will be discarded (not written), and we will success in 'pushing more data to the stream buffer after a hole'?" > buf->pos += (ptrdiff_t)lj_utils_write_uleb128(buf->pos, n); > } > > @@ -91,11 +100,14 @@ void lj_wbuf_addn(struct lj_wbuf *buf, const void *src, size_t n) > memcpy(buf->pos, src, left); > buf->pos += (ptrdiff_t)left; > lj_wbuf_flush(buf); > + if (LJ_UNLIKELY(lj_wbuf_test_flag(buf, STREAM_STOP))) > + return; "What would happen if writer() reports an error, but doesn't stop a stream?" > src = (uint8_t *)src + (ptrdiff_t)left; > n -= left; > } > > - wbuf_reserve(buf, n); > + if (LJ_UNLIKELY(!wbuf_reserve(buf, n))) > + return; > memcpy(buf->pos, src, n); > buf->pos += (ptrdiff_t)n; > } -- -- Best regards, Evgeniy Temirgaleev