From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Serge Petrenko Message-Id: <90480C3B-12BD-4B8E-9D8B-A1C887EAFBB1@tarantool.org> Content-Type: multipart/alternative; boundary="Apple-Mail=_B88D1C6B-CE33-48CC-B214-1E33737C69E5" Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.8\)) Subject: Re: [tarantool-patches] Re: [PATCH] test: rework box/misc test part regarding on_shutdown triggers Date: Fri, 12 Apr 2019 17:35:24 +0300 In-Reply-To: <20190412142057.3aa6v6ib3toupu2o@esperanza> References: <20190411133720.39993-1-sergepetrenko@tarantool.org> <20190412140023.geyzk47gkwws7wns@esperanza> <20190412142057.3aa6v6ib3toupu2o@esperanza> To: Vladimir Davydov Cc: tarantool-patches@freelists.org List-ID: --Apple-Mail=_B88D1C6B-CE33-48CC-B214-1E33737C69E5 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > 12 =D0=B0=D0=BF=D1=80. 2019 =D0=B3., =D0=B2 17:20, Vladimir Davydov = =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0=B0=D0=BB(=D0=B0= ): >=20 > On Fri, Apr 12, 2019 at 05:12:11PM +0300, Serge Petrenko wrote: >>>> test_run:cmd("switch default") >>>> +test_run:eval("test", "_ =3D fiber.new(function() os.exit() while = true do end end)") >>>=20 >>> This is supposed to stop the default instance?! >>=20 >> No, it=E2=80=99s evaled on =E2=80=99test=E2=80=99, which is the other = instance. And that=E2=80=99s why we need the require(=E2=80=98fiber=E2=80=99= ) above. >> Anyways, will split the patch in two and resend. >=20 > Missed the eval, sorry. It=E2=80=99s ok. I=E2=80=99ve resent the patch. Please see '[PATCH v2 0/2] Rework = on_shutdown test for better stability.'= --Apple-Mail=_B88D1C6B-CE33-48CC-B214-1E33737C69E5 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=utf-8

12 =D0=B0=D0=BF=D1=80. 2019 =D0=B3., =D0=B2 17:20, Vladimir = Davydov <vdavydov.dev@gmail.com> =D0=BD=D0=B0=D0=BF=D0=B8=D1=81=D0= =B0=D0=BB(=D0=B0):

On Fri, Apr 12, 2019 at 05:12:11PM +0300, = Serge Petrenko wrote:
test_run:cmd("switch default")
+test_run:eval("test", "_ =3D fiber.new(function() os.exit() = while true do end end)")

This = is supposed to stop the default instance?!

No, it=E2=80=99s evaled on =E2=80=99test=E2=80=99, which is = the other instance. And that=E2=80=99s why we need the = require(=E2=80=98fiber=E2=80=99) above.
Anyways, will = split the patch in two and resend.

Missed the eval, sorry.
It=E2=80=99s ok.
I=E2=80=99ve resent the patch. Please see '[PATCH v2 0/2] Rework on_shutdown test for = better stability.'
= --Apple-Mail=_B88D1C6B-CE33-48CC-B214-1E33737C69E5--