From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 054CA29E53 for ; Thu, 16 Aug 2018 16:58:23 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id o0CLV5-aViGA for ; Thu, 16 Aug 2018 16:58:22 -0400 (EDT) Received: from smtp53.i.mail.ru (smtp53.i.mail.ru [94.100.177.113]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id AB36229E64 for ; Thu, 16 Aug 2018 16:58:06 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] app: example.lua does not start References: <577c0a6a34b9ed0c41d84257bae3da0bcaffec19.1534419170.git.imeevma@gmail.com> From: Vladislav Shpilevoy Message-ID: <90212d19-59e8-8778-a86b-803ae4663ff9@tarantool.org> Date: Thu, 16 Aug 2018 23:58:03 +0300 MIME-Version: 1.0 In-Reply-To: <577c0a6a34b9ed0c41d84257bae3da0bcaffec19.1534419170.git.imeevma@gmail.com> Content-Type: text/plain; charset="utf-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, imeevma@tarantool.org Hi! Thanks for the patch! LGTM. I have pushed the patch into 2.0. On 16/08/2018 14:35, imeevma@tarantool.org wrote: > According to #3072 log_nonblock cannot be used in > given case. This patch set this option to "false". > > Closes #3348 > --- > Branch: https://github.com/tarantool/tarantool/tree/imeevma/gh-3348-example-lua-does-not-start > Issue: https://github.com/tarantool/tarantool/issues/3348 > > extra/dist/example.lua | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/extra/dist/example.lua b/extra/dist/example.lua > index 0aa51c6..153d831 100644 > --- a/extra/dist/example.lua > +++ b/extra/dist/example.lua > @@ -136,7 +136,7 @@ box.cfg { > > -- If true, tarantool does not block on the log file descriptor > -- when it’s not ready for write, and drops the message instead > - log_nonblock = true; > + log_nonblock = false; > > -- If processing a request takes longer than > -- the given value (in seconds), warn about it in the log >