From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 99B022569E for ; Wed, 16 Jan 2019 09:26:03 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id hE-VSuXF0KRR for ; Wed, 16 Jan 2019 09:26:03 -0500 (EST) Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 8966A25819 for ; Wed, 16 Jan 2019 09:26:02 -0500 (EST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 12.0 \(3445.100.39\)) Subject: [tarantool-patches] Re: [PATCH 2/8] sql: use field type instead of affinity for type_def From: "n.pettik" In-Reply-To: Date: Wed, 16 Jan 2019 17:26:00 +0300 Content-Transfer-Encoding: quoted-printable Message-Id: <900273B1-31E1-4EA8-8984-0216410E6552@tarantool.org> References: Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org Cc: Vladislav Shpilevoy > On 29 Dec 2018, at 19:42, Vladislav Shpilevoy = wrote: >=20 > Thanks for the patch! See 1 comment below. >=20 > If I were you, I would moved this function to field_def.c/.h, but > taking into account that it is a temporary crutch anyway, it is up > to you. Since it is temporary auxiliary function, lets keep it as is.