From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 0EE676FC8F; Fri, 16 Apr 2021 02:12:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 0EE676FC8F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618528362; bh=ypa519la2My+zqUTJ8B2F/o7nh/DregyE/+kTTLfz8E=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=nl7Sql94FT12VFLbUIsIcc020RrbF974RQkPYBMu1NMhlQFJ3rzgnpNNA79lnJg6F wQ9nqfnZnMlsG+QKh6oNAFngW/27AFGFNNq+4pcKVlAhpUuxNC9FuBZ8YqMFObqbSI M3n/r7bVLAZkk/AV/xjXzyoYUl2raDTd8ArUbbpE= Received: from smtp59.i.mail.ru (smtp59.i.mail.ru [217.69.128.39]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 68C6D6FC8F for ; Fri, 16 Apr 2021 02:12:40 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 68C6D6FC8F Received: by smtp59.i.mail.ru with esmtpa (envelope-from ) id 1lXBA7-0004LN-5u; Fri, 16 Apr 2021 02:12:39 +0300 To: Cyrill Gorcunov , tml References: <20210415220619.27208-1-gorcunov@gmail.com> Message-ID: <8f84416e-440e-8f31-e673-f182fd402c18@tarantool.org> Date: Fri, 16 Apr 2021 01:12:37 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <20210415220619.27208-1-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E74809299FB6B3996B874F289A033C44AD400182A05F5380850401BA481513318882A7B9BD57B51A744F14E84F67941A37B7FD89D5E9BEEE439AA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7BC08626EA5717D14EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637E8F1A1743CF948808638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B22E59C24E67A2DCB5D1EF1C020DB2B2D53999716826408816D2E47CDBA5A96583C09775C1D3CA48CF0942DC5495D0595E117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE78C9B9C945842D50B9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7E2D1D19D77E2F9D0D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0B3D74630A5763800CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3483320834B361D1F089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4AD6C30AE2B5E62355B71240D1532D56FF6 X-C1DE0DAB: 0D63561A33F958A56EE68EEC64874EB60503B3495298F6C1A6CA2ADE94B60A1CD59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D348F1757F8DFBC5C33E9E19C8994F1C5A9FA9A4EC68AFB4F570A8504F3691E5E8BE0B345E6B56B34321D7E09C32AA3244CA117CD053E4E5C19DB6D66991E5C29808A6D4CC6FBFAC251927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj3S6P1v0GIqQZ0z4iRfNmVg== X-Mailru-Sender: 504CC1E875BF3E7D9BC0E5172ADA31103DA95E6708EF203814B6342CB799400EB7A3AAED7642DA1207784C02288277CA03E0582D3806FB6A5317862B1921BA260ED6CFD6382C13A6112434F685709FCF0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH] txn_limbo: simplify owner migration condition X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thanks for the patch! On 16.04.2021 00:06, Cyrill Gorcunov wrote: > When limbo owner is about to change the state > we should check is if there are some pending 'is' is not needed. > transactions are not yet processed, iow if are -> which are. > queue is empty. No need to test if current limbo > owner is zero. The owner is set to zero once -- > when limbo is created during initialization. > > After all I think even if owner would ever zero > and we're about to change it the queue simply > must be empty, that is the only safe state.