From: Vladislav Shpilevoy via Tarantool-patches <tarantool-patches@dev.tarantool.org>
To: Cyrill Gorcunov <gorcunov@gmail.com>,
tml <tarantool-patches@dev.tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] txn_limbo: simplify owner migration condition
Date: Fri, 16 Apr 2021 01:12:37 +0200 [thread overview]
Message-ID: <8f84416e-440e-8f31-e673-f182fd402c18@tarantool.org> (raw)
In-Reply-To: <20210415220619.27208-1-gorcunov@gmail.com>
Hi! Thanks for the patch!
On 16.04.2021 00:06, Cyrill Gorcunov wrote:
> When limbo owner is about to change the state
> we should check is if there are some pending
'is' is not needed.
> transactions are not yet processed, iow if
are -> which are.
> queue is empty. No need to test if current limbo
> owner is zero. The owner is set to zero once --
> when limbo is created during initialization.
>
> After all I think even if owner would ever zero
> and we're about to change it the queue simply
> must be empty, that is the only safe state.
next prev parent reply other threads:[~2021-04-15 23:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-15 22:06 Cyrill Gorcunov via Tarantool-patches
2021-04-15 23:12 ` Vladislav Shpilevoy via Tarantool-patches [this message]
2021-04-16 7:17 ` [Tarantool-patches] [PATCH v2] " Cyrill Gorcunov via Tarantool-patches
2021-04-16 19:29 ` Vladislav Shpilevoy via Tarantool-patches
2021-04-16 20:36 ` Cyrill Gorcunov via Tarantool-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f84416e-440e-8f31-e673-f182fd402c18@tarantool.org \
--to=tarantool-patches@dev.tarantool.org \
--cc=gorcunov@gmail.com \
--cc=v.shpilevoy@tarantool.org \
--subject='Re: [Tarantool-patches] [PATCH] txn_limbo: simplify owner migration condition' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox