From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH v4 02/12] evio: expose
 evio_setsockopt_server function
References: <cover.1548883137.git.v.shpilevoy@tarantool.org>
 <95b265f0fff41d30076f92e282bbcbda96984f72.1548883137.git.v.shpilevoy@tarantool.org>
 <20190215132158.GE24683@chai>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <8f7af8cc-7231-3c93-fe28-a17d7c6c8954@tarantool.org>
Date: Sat, 16 Feb 2019 00:22:48 +0300
MIME-Version: 1.0
In-Reply-To: <20190215132158.GE24683@chai>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To: tarantool-patches@freelists.org, Konstantin Osipov <kostja@tarantool.org>
Cc: vdavydov.dev@gmail.com
List-ID: <tarantool-patches.dev.tarantool.org>

Pushed to 2.1.

On 15/02/2019 14:21, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [19/01/31 10:28]:
>> It is going to be used in SWIM module to set UDP server socket
>> options. Apparently this function sets some usefull flags like
>> NONBLOCK, REUSEADDR.
> 
> A bit more detailed comment wouldn't harm for a public function:
> which options this function is setting and why.
> 
> Otherwise OK to push.
> 
> 
> -- 
> Konstantin Osipov, Moscow, Russia, +7 903 626 22 32
> http://tarantool.io - www.twitter.com/kostja_osipov
>