From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 6EBDB509471; Thu, 13 Jul 2023 12:58:46 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 6EBDB509471 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1689242326; bh=uv1XzgeD4UqnOeoVWyLTXGyts1HSZH/IWIovXwYT+4U=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=qPZad6zgwpuaUgS4WVxzf4dz4g8ws9Skb8XeGe5aMcgAfitHKh4xN4iTIkDS75fz6 D4JAsSr87Hy2mzYh2iw0Swp7SJ/eg5EOWMhRSt1Xi/ktQIvuLojIHsQnYMB8v5GzWu eRVdbL9+vMoUr9SeuV/v6L/Hi5AV0IL5kILH8VLY= Received: from smtp48.i.mail.ru (smtp48.i.mail.ru [95.163.41.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 8FB3C4F62AF for ; Thu, 13 Jul 2023 12:58:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8FB3C4F62AF Received: by smtp48.i.mail.ru with esmtpa (envelope-from ) id 1qJt5w-009zuo-KA; Thu, 13 Jul 2023 12:58:45 +0300 Message-ID: <8f2e48d3-3a13-c9f1-46fa-836df321db8b@tarantool.org> Date: Thu, 13 Jul 2023 12:58:44 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Content-Language: en-US To: Igor Munkin , Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <73e2376cd179a89d8be7c0a277e6cab3fecb95bd.1689184997.git.imun@tarantool.org> In-Reply-To: <73e2376cd179a89d8be7c0a277e6cab3fecb95bd.1689184997.git.imun@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9B2A9E02D3479B2E06D238632EDD918ADE99D1207B41AAA03182A05F538085040A9D7A833ED1A0B644E8873772CED7F1F154E9D6E87E8F224F976AC4FA7898B4D X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE77E216A0E97507353EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063788758EA7442DD2858638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8A8528120822ED890779ACF40C64F97D2117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC3A703B70628EAD7BA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F4460429728776938767073520652FD71AFB96DC7DE5D25F19253116ADD2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE26055571C92BF10F287C8E22D4AE2A51D8FC6C240DEA76429C9F4D5AE37F343AA9539A8B242431040A6AB1C7CE11FEE32D01283D1ACF37BA302FCEF25BFAB345C4224003CC836476E2F48590F00D11D6E2021AF6380DFAD1A18204E546F3947C062BEEFFB5F8EA3E2E808ACE2090B5E1725E5C173C3A84C3C5EA940A35A165FF2DBA43225CD8A89F83C798A30B85E16BA91E23F1B6B78B78B5C8C57E37DE458BEDA766A37F9254B7 X-C1DE0DAB: 0D63561A33F958A547A4579D0D8EFB4AD90D84016B06E527D66AF5353BC59BF5F87CCE6106E1FC07E67D4AC08A07B9B01DAA61796BF5227BCB5012B2E24CD356 X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFCE795ADCDA70BE117A96BF69919773517850C9EE70B1EB79BA3969CC1FE3C9AD68A36B291CE9B2EB399DF444199BC1D1392F1DF79D053ECE851CA548F8BEA64EE48CAC7CA610320002C26D483E81D6BE0DBAE6F56676BC7117BB6831D7356A2DEC5B5AD62611EEC62B5AFB4261A09AF0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojmIyQFW4pVcmdCKHRHFW2jA== X-Mailru-Sender: 49D287FBCBBF3A5C1746B9497B71E89EEB77ACBE81E22FB14E8873772CED7F1F7962F9E9328436E1EBA65886582A37BD66FEC6BF5C9C28D98A98C1125256619760D574B6FC815AB872D6B4FCE48DF648AE208404248635DF X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit] ci: update job concurrency group definition X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Igor! Thanks for the patch! LGTM On 7/12/23 21:06, Igor Munkin wrote: > As a result of branch renaming in LuaJIT repository, the existing job > concurrency group definition rule has become outdated. This patch > updates the condition according to the new branch naming policy. > > Signed-off-by: Igor Munkin > --- > > Branch: https://github.com/tarantool/luajit/tree/imun/ci-update-job-concurrency-group-def > > .github/workflows/exotic-builds-testing.yml | 12 +++++------- > .github/workflows/gnumake-builds-testing.yml | 12 +++++------- > .github/workflows/lint.yml | 12 +++++------- > .github/workflows/testing.yml | 12 +++++------- > 4 files changed, 20 insertions(+), 28 deletions(-) > > diff --git a/.github/workflows/exotic-builds-testing.yml b/.github/workflows/exotic-builds-testing.yml > index 2269928f..318fb4dd 100644 > --- a/.github/workflows/exotic-builds-testing.yml > +++ b/.github/workflows/exotic-builds-testing.yml > @@ -11,8 +11,8 @@ on: > concurrency: > # An update of a developer branch cancels the previously > # scheduled workflow run for this branch. However, the default > - # branch, and long-term branch (tarantool-1.10, tarantool-2.8, > - # etc.) workflow runs are never canceled. > + # branch, and long-term branch (tarantool/release/2.11, > + # tarantool/release/2.10, etc) workflow runs are never canceled. > # > # We use a trick here: define the concurrency group as 'workflow > # run ID' + # 'workflow run attempt' because it is a unique > @@ -21,11 +21,9 @@ concurrency: > # XXX: we cannot use `github.sha` as a unique identifier because > # pushing a tag may cancel a run that works on a branch push > # event. > - group: ${{ ( > - github.ref == 'refs/heads/tarantool' || > - startsWith(github.ref, 'refs/heads/tarantool-')) && > - format('{0}-{1}', github.run_id, github.run_attempt) || > - format('{0}-{1}', github.workflow, github.ref) }} > + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') > + && format('{0}-{1}', github.run_id, github.run_attempt) > + || format('{0}-{1}', github.workflow, github.ref) }} > cancel-in-progress: true > > jobs: > diff --git a/.github/workflows/gnumake-builds-testing.yml b/.github/workflows/gnumake-builds-testing.yml > index b78823f1..afb96183 100644 > --- a/.github/workflows/gnumake-builds-testing.yml > +++ b/.github/workflows/gnumake-builds-testing.yml > @@ -11,8 +11,8 @@ on: > concurrency: > # An update of a developer branch cancels the previously > # scheduled workflow run for this branch. However, the default > - # branch, and long-term branch (tarantool-1.10, tarantool-2.8, > - # etc.) workflow runs are never canceled. > + # branch, and long-term branch (tarantool/release/2.11, > + # tarantool/release/2.10, etc) workflow runs are never canceled. > # > # We use a trick here: define the concurrency group as 'workflow > # run ID' + # 'workflow run attempt' because it is a unique > @@ -21,11 +21,9 @@ concurrency: > # XXX: we cannot use `github.sha` as a unique identifier because > # pushing a tag may cancel a run that works on a branch push > # event. > - group: ${{ ( > - github.ref == 'refs/heads/tarantool' || > - startsWith(github.ref, 'refs/heads/tarantool-')) && > - format('{0}-{1}', github.run_id, github.run_attempt) || > - format('{0}-{1}', github.workflow, github.ref) }} > + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') > + && format('{0}-{1}', github.run_id, github.run_attempt) > + || format('{0}-{1}', github.workflow, github.ref) }} > cancel-in-progress: true > > jobs: > diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml > index 71ceee9a..70c98104 100644 > --- a/.github/workflows/lint.yml > +++ b/.github/workflows/lint.yml > @@ -11,8 +11,8 @@ on: > concurrency: > # An update of a developer branch cancels the previously > # scheduled workflow run for this branch. However, the default > - # branch, and long-term branch (tarantool-1.10, tarantool-2.8, > - # etc.) workflow runs are never canceled. > + # branch, and long-term branch (tarantool/release/2.11, > + # tarantool/release/2.10, etc) workflow runs are never canceled. > # > # We use a trick here: define the concurrency group as 'workflow > # run ID' + # 'workflow run attempt' because it is a unique > @@ -21,11 +21,9 @@ concurrency: > # XXX: we cannot use `github.sha` as a unique identifier because > # pushing a tag may cancel a run that works on a branch push > # event. > - group: ${{ ( > - github.ref == 'refs/heads/tarantool' || > - startsWith(github.ref, 'refs/heads/tarantool-')) && > - format('{0}-{1}', github.run_id, github.run_attempt) || > - format('{0}-{1}', github.workflow, github.ref) }} > + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') > + && format('{0}-{1}', github.run_id, github.run_attempt) > + || format('{0}-{1}', github.workflow, github.ref) }} > cancel-in-progress: true > > jobs: > diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml > index 8300c443..2c637124 100644 > --- a/.github/workflows/testing.yml > +++ b/.github/workflows/testing.yml > @@ -11,8 +11,8 @@ on: > concurrency: > # An update of a developer branch cancels the previously > # scheduled workflow run for this branch. However, the default > - # branch, and long-term branch (tarantool-1.10, tarantool-2.8, > - # etc.) workflow runs are never canceled. > + # branch, and long-term branch (tarantool/release/2.11, > + # tarantool/release/2.10, etc) workflow runs are never canceled. > # > # We use a trick here: define the concurrency group as 'workflow > # run ID' + # 'workflow run attempt' because it is a unique > @@ -21,11 +21,9 @@ concurrency: > # XXX: we cannot use `github.sha` as a unique identifier because > # pushing a tag may cancel a run that works on a branch push > # event. > - group: ${{ ( > - github.ref == 'refs/heads/tarantool' || > - startsWith(github.ref, 'refs/heads/tarantool-')) && > - format('{0}-{1}', github.run_id, github.run_attempt) || > - format('{0}-{1}', github.workflow, github.ref) }} > + group: ${{ startsWith(github.ref, 'refs/heads/tarantool/') > + && format('{0}-{1}', github.run_id, github.run_attempt) > + || format('{0}-{1}', github.workflow, github.ref) }} > cancel-in-progress: true > > jobs: