From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 8111C6EFD6; Tue, 29 Sep 2026 13:33:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 8111C6EFD6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1790677983; bh=xHsTJEUUM+VF5O9OIX7iSfQxPAd10Vm093wimnqdTW8=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mi2JOMZ/NAc2NfRrrNFz1En69Ec705+53Tcyr9jyEfdDQwyMtDYsUMTTPEF7qv/vr W78biokXpJfE2Ums4IlxiEXhdOfeDQEHNsXq3vCtFZ32+eH2Uo7R+qTqAiw3ilYL67 jFPTYA0BJ1sDdfAocokwGlN2p2Dql56aT/4DIbf0= Received: from send196.i.mail.ru (send196.i.mail.ru [95.163.59.35]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 121DA6EFD6 for ; Tue, 29 Sep 2026 13:33:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 121DA6EFD6 Received: by exim-smtp-65f8d7bcb-nwnk9 with esmtpa (envelope-from ) id 1xBV8v-00000000LAl-3myc; Tue, 29 Sep 2026 13:33:02 +0300 Message-ID: <8e0df2ae-b318-4657-9e99-438ab2d07538@tarantool.org> Date: Tue, 29 Sep 2026 13:33:00 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: Sergey Bronnikov References: <9d4e2c67dcc3640a917a649cfcd2f19253ddd2f1.1786019520.git.e.temirgaleev@tarantool.org> <5798e367-3daa-4fe1-b9e0-5fec24d52082@tarantool.org> <1787929924.462961851@f483.i.mail.ru> <67760a66-15f3-41c2-bc20-16a2f9649a5f@tarantool.org> <4ba8ba55-c3f1-40d2-acc0-137bbcb9dadc@tarantool.org> Content-Language: en-US In-Reply-To: <4ba8ba55-c3f1-40d2-acc0-137bbcb9dadc@tarantool.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94B2D473D652AD5AC582D7B5C076E307B33E6DE7A156F3BF2182A05F538085040C3231ED2E26AC3253DE06ABAFEAF6705D65DA96C8B8B3C3C8BB20D4CEC4DC45A0134F15712FB01B7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE710FC7AC39A8009ECEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637FE9EFE935CD7C6AE8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B2BDA49613908D434F2E070BE324C7D3C4F54A2BADD09A4949F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C091DAD9F922AA71188941B15DA834481F9449624AB7ADAF37BA3038C0950A5D36D5E8D9A59859A8B60D0E8DD5A242ADE476E601842F6C81A1F004C906525384303E02D724532EE2C3F43C7A68FF6260569E8FC8737B5C2249EC8D19AE6D49635B68655334FD4449CB9ECD01F8117BC8BEAAAE862A0553A39223F8577A6DFFEA7C4DCCFF368A6260CFC4224003CC83647689D4C264860C145E X-C1DE0DAB: 0D63561A33F958A595F7225908A5AE245002B1117B3ED6966FF6AA67BD0CDE8CC89B063BDC7FAC35823CB91A9FED034534781492E4B8EEADAE4FDBF11360AC9BBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D6596EF3CB38BB29E234346377967CCC814C7F84BC0DA4706085D9E8C301D3BEEA46742B4046F76425A2B8341EE9D5BE9A0A9D4ED15F721A033EDCE7F44498E4310949755EBAC31E31826536EB022892E5344C41F94D744909CEEF9E35A692215F79327F81E6EEE0AEB67A0F9F91F029B6AF33F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXOcIETfglQORZ0zpDET4Zrk3igikrdHlWPEWcd2ReUtPDLEd9SnCO68= X-Mailru-Sender: 9482C2B233321BD2866703C3B73F805512001317BEF488936750B362712FA5BD5219154F2F8322386B3DCC7CEB8B56F18C34D365DA2E1307B60569B44082A3A3197AF8DA6C69D34BA7BD66BEAC8CCB0C4198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit v3 2/3] ci: enabled sanitizer tests for macOS X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Evgeniy Temirgaleev via Tarantool-patches Reply-To: Evgeniy Temirgaleev Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! The comment's place change is reverted. The branch is force pushed. 28.09.2026 16:10, Sergey Bronnikov пишет: > Hi, Evgeniy, > > thanks for fixes! LGTM with a minor comment. > > On 9/24/26 11:49, Evgeniy Temirgaleev wrote: >> >>> >>> 3. I don't like that we have three copies of ASAN_OPTIONS in the same >>> workflow. It is better to fix this. >> >> Fixed. > > Thanks! > > Why this hunk was moved? Please revert: > > + > +      # Enable as much checks as possible. See more info here: > +      # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags, > +      # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags. > +      - name: setup common sanitizer options >          env: > -          # Enable as much checks as possible. See more info here: > -          # https://github.com/google/sanitizers/wiki/ > AddressSanitizerFlags, > -          # https://github.com/google/sanitizers/wiki/ > SanitizerCommonFlags. >            ASAN_OPTIONS: "                    \ >              detect_invalid_pointer_pairs=1:  \ >              detect_leaks=1: -- diff --git a/.github/workflows/sanitizers-testing.yml b/.github/workflows/sanitizers-testing.yml index bc163408..b8eaf581 100644 --- a/.github/workflows/sanitizers-testing.yml +++ b/.github/workflows/sanitizers-testing.yml @@ -114,11 +114,11 @@ jobs: - name: build run: cmake --build . --parallel working-directory: ${{ env.BUILDDIR }} - # Enable as much checks as possible. See more info here: - # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags, - # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags. - name: setup common sanitizer options env: + # Enable as much checks as possible. See more info here: + # https://github.com/google/sanitizers/wiki/AddressSanitizerFlags, + # https://github.com/google/sanitizers/wiki/SanitizerCommonFlags. ASAN_OPTIONS: " \ detect_invalid_pointer_pairs=1: \ detect_leaks=1: \ -- Best regards, Evgeniy Temirgaleev