From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 53DE4A04F42; Wed, 7 Feb 2024 11:04:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 53DE4A04F42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1707293085; bh=rykzGeNjurViffnOFmGTttk/EuDgLy86QuLC5WaL3Zk=; h=Date:To:References:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=HiPKeiJUEYyQiEUicWdAyXHqy6m8J7nHs7nhdiCGXe+b1sShQn0iDCoxYrDi8rB1r efDGvIDpuxaxBXNS4YJz3z6MuNgoOXMTJmCcxvhMehNR9kMYBwYmXBJLw03q4XjLvv 8KydcRbaDKgVSY5O736abVCCynMbD3pPp/3Bv88I= Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [95.163.41.78]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id B7ED956CD16 for ; Wed, 7 Feb 2024 11:04:44 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org B7ED956CD16 Received: by smtp37.i.mail.ru with esmtpa (envelope-from ) id 1rXcvD-0000000Gyn0-1yIP; Wed, 07 Feb 2024 11:04:44 +0300 Message-ID: <8df381d8-7921-4d31-89c9-16e9f52ad9e5@tarantool.org> Date: Wed, 7 Feb 2024 11:04:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun References: <2d1cb0d61396fbc7d6efd352ed540079df684477.1706520765.git.skaplun@tarantool.org> <72954849-cd6c-435d-a65d-d379674dabdc@tarantool.org> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD94C460F083DF69F51B9726ADA31168F4196B22ED51EBCAFDA182A05F53808504025DBEC6A51039BB0479CDAE959BF6424F7CAFF2E9277610B591D17B302A7708A261E30AE1A3D8EFE X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7D63A32B630C59AACEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637803A71E7516670C28638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D880EF22D5EAA980AD972BC063C4C8A5FF495D33716F7764FECC7F00164DA146DAFE8445B8C89999728AA50765F7900637F924B32C592EA89F389733CBF5DBD5E9C8A9BA7A39EFB766F5D81C698A659EA7CC7F00164DA146DA9985D098DBDEAEC82FFDA4F57982C5F4F6B57BC7E6449061A352F6E88A58FB86F5D81C698A659EA73AA81AA40904B5D9A18204E546F3947C4D3DDB508812D9006E0066C2D8992A164AD6D5ED66289B523666184CF4C3C14F6136E347CC761E07725E5C173C3A84C3A44938D9598B9AADBA3038C0950A5D36B5C8C57E37DE458B330BD67F2E7D9AF16D1867E19FE14079C09775C1D3CA48CFE478A468B35FE7671DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C31BC2FD6A5287AC5335872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A55656492B3ADAAD8F5002B1117B3ED696A843532EFF8AFBA822DFD5397F446790823CB91A9FED034534781492E4B8EEADBD39A56654533F91BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF6C4316939F69DA06EEFE6480AED62A3718C3B54696738C1A7ED52CFE7E6116E0D2D1C8B3CBCE0EE8807D692F32DC7032434E14F36CC5B524A9E9A3C573AEBFC5A3B46A4E92EA18745F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojh/iSjD2txnOqy6oW5qtJUw== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F258845877E641D33A7857DDF33F69C7E48EA1FBA772B9C75109581E09EC85AF829BF04F645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 18/26] test: enable in LuaJIT-tests X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi, Sergey! thanks! LGTM On 2/6/24 17:12, Sergey Kaplun wrote: > Hi, Sergey! > Thanks for the review! > Fixed your comment below. > > On 05.02.24, Sergey Bronnikov wrote: >> Hi, Sergey >> >> thanks for the patch! LGTM wit a minor comment >> >> On 1/29/24 13:45, Sergey Kaplun wrote: >>> This patch changes `dofile()` (which uses an unreliable relative file >>> path and mutates `_G` with global functions to be defined) to the >>> corresponding `require()` of the helper functions. It adds groups with >>> the names of subtests and enables the test in . >>> >>> Part of tarantool/tarantool#9398 >>> --- >>> test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua | 106 ++++++++++-------- >>> test/LuaJIT-tests/lib/ffi/index | 1 + >>> 2 files changed, 58 insertions(+), 49 deletions(-) >>> >>> diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua >>> index 3a9616d7..d3b02759 100644 >>> --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua >>> +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua >>> @@ -1,58 +1,66 @@ >>> local ffi = require("ffi") >> >>> >>> -do >>> +do --- sizeof VLA >> it is inconsistent with test name at least in a previous patch. >> >> Here: "sizeof VLA", in a previous patch "VLA". >> >> Feel free to ignore. > Renamed as the following: > > =================================================================== > diff --git a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > index d3b02759..ce82f5da 100644 > --- a/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > +++ b/test/LuaJIT-tests/lib/ffi/ffi_parse_array.lua > @@ -4,7 +4,7 @@ local checkfail = require("common.ffi.checkfail") > local checktypes = require("common.ffi.checktypes") > local fails = require("common.fails") > > -do --- checkfail > +do --- incorrect declarations > checkfail{ > "int [", > "int [-1]", > @@ -33,8 +33,7 @@ do --- sizeof of arrays > assert(ffi.sizeof("foo2_array_t") == 200) > end > > - > -do --- checktypes > +do --- array declarations, sizeof() and alignof() > local P = ffi.sizeof("void *") > checktypes{ > 10, 1, "char [10]", > @@ -60,7 +59,7 @@ do --- checktypes > } > end > > -do --- sizeof VLA > +do --- VLA sizeof > assert(ffi.sizeof("int [?]", 10) == 4*10) > local id = ffi.typeof("const short [?]") > assert(ffi.sizeof(id, 10) == 2*10) > @@ -72,7 +71,7 @@ do --- sizeof VLA > assert(ffi.sizeof(id, 0x3fffffff) == 2*0x3fffffff) > end > > -do --- sizeof VLS > +do --- VLS sizeof > assert(ffi.sizeof("struct { double x; int a[?]; }", 10) == 8+4*10) > local id = ffi.typeof("struct { int x; short a[?]; }") > assert(ffi.sizeof(id, 10) == 4+2*10) > =================================================================== > > > >>> jit_complex.lua