From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id 785CC2C8FC for ; Mon, 19 Nov 2018 07:41:02 -0500 (EST) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id g405XjVdufJI for ; Mon, 19 Nov 2018 07:41:02 -0500 (EST) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 3836C2C8FA for ; Mon, 19 Nov 2018 07:41:02 -0500 (EST) Subject: [tarantool-patches] Re: [PATCH] sql: constraints definition among columns in CREATE TABLE() References: <20181118143151.24016-1-roman.habibov1@yandex.ru> From: Vladislav Shpilevoy Message-ID: <8d84eb1f-95c4-0043-abc7-dc19f663a0df@tarantool.org> Date: Mon, 19 Nov 2018 15:41:00 +0300 MIME-Version: 1.0 In-Reply-To: <20181118143151.24016-1-roman.habibov1@yandex.ru> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Roman Khabibov Hi! Thanks for the patch! Please, fix one minor comment below. On 18/11/2018 17:31, Roman Khabibov wrote: > Allow constraints to appear along with columns definitions. Disallow typing > a constraint name without specifying the constraint and after. > > Closes #3504 > > Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3504-constraints-create-table > Issue: https://github.com/tarantool/tarantool/issues/3504 > diff --git a/test/sql-tap/table.test.lua b/test/sql-tap/table.test.lua > index 8367ec016..65b45de0a 100755 > --- a/test/sql-tap/table.test.lua > +++ b/test/sql-tap/table.test.lua > @@ -1,6 +1,6 @@ > #!/usr/bin/env tarantool > test = require("sqltester") > -test:plan(57) > +test:plan(68) > > --!./tcltestrunner.lua > -- 2001 September 15 > @@ -1180,4 +1180,143 @@ test:do_test( Please, add a test that I can not write multiple 'CONSTRAINT ' in a row. > > -- > })