From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp57.i.mail.ru (smtp57.i.mail.ru [217.69.128.37]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 79C3E4696C5 for ; Tue, 4 Feb 2020 01:17:22 +0300 (MSK) References: From: Vladislav Shpilevoy Message-ID: <8d7111f9-8116-5374-c948-1884242af619@tarantool.org> Date: Mon, 3 Feb 2020 23:17:20 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [Tarantool-patches] [PATCH v4 0/3] box: session settings fixes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Chris Sosnin , tarantool-patches@dev.tarantool.org Hi! Thanks for the patchset! I see that you have 1 more commit on top of the ones listed below. Please, next time send 2 separate branches. On 28/01/2020 13:50, Chris Sosnin wrote: > Changes in v3: > - add a patch that removes setting modules > - apply Vlad's fixes > > Changes in v4: > - add lua frontend for accessing session settings > - move settings initialization into session.c > > branch: https://github.com/tarantool/tarantool/tree/ksosnin/gh-4712-search-settings > issue #1: https://github.com/tarantool/tarantool/issues/4711 > issue #2: https://github.com/tarantool/tarantool/issues/4712 > > Chris Sosnin (3): > box: replace session_settings modules with a single array > box: add binary search for _session_settings space > box: provide a user friendly frontend for accessing session settings > > src/box/lua/session.c | 106 +++++++++++ > src/box/session_settings.c | 180 +++++++++++------- > src/box/session_settings.h | 47 +++-- > src/box/sql.c | 5 - > src/box/sql/build.c | 60 ++---- > ...1-access-settings-from-any-frontend.result | 94 +++++++-- > ...access-settings-from-any-frontend.test.lua | 45 ++++- > 7 files changed, 378 insertions(+), 159 deletions(-) >