From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id BED406BD29; Tue, 13 Apr 2021 16:16:04 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org BED406BD29 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1618319764; bh=DjU4sYJBtau2doZxMl0P+YvW92hu9Cwt1Zc1fcfo+VI=; h=To:Cc:References:Date:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=iuMndAUtPr0TxQwTXeC7mJPy895qWKMtNpKitjVnERBc3YkvRU2GBaHKafS9EggTS 5CekJMqaIt+gV0YkEfLdhhi6wFOpUa1xR+SqgZNZ+2YOzonOzdYEBiMi5yYW8lx7oJ JRyY+b6xwUhnH23bCUi4TC8lzWt7Xd6wML3ZMMvI= Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 95CB46BD29 for ; Tue, 13 Apr 2021 16:16:03 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 95CB46BD29 Received: by smtp31.i.mail.ru with esmtpa (envelope-from ) id 1lWIte-000826-Oc; Tue, 13 Apr 2021 16:16:03 +0300 To: Roman Khabibov , tarantool-patches@dev.tarantool.org Cc: alexander.turenko@tarantool.org References: <20210319141308.98726-1-roman.habibov@tarantool.org> Message-ID: <8d5f9e4d-ccf7-61bb-d80f-b285342f1b04@tarantool.org> Date: Tue, 13 Apr 2021 16:14:28 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20210319141308.98726-1-roman.habibov@tarantool.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD92FFCB8E6708E7480257C85EA0BB7A95D0F00AE41BB9A5343182A05F53808504099AE8A9F53C44D622F912B026F06E9EC8E918444531D3FE3EA54695A06122E30 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE70043D879A87EF1BCEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063748744D4CD6EC491D8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B234F63B5B8388C44741AE37F2D1CFD0420E47C10036089472D2E47CDBA5A96583C09775C1D3CA48CF17B107DEF921CE79117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE767883B903EA3BAEA9FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE793D6E5F245F405F3D32BA5DBAC0009BE395957E7521B51C20BC6067A898B09E4090A508E0FED6299176DF2183F8FC7C0E72BA08CD36276B6CD04E86FAF290E2D7E9C4E3C761E06A71DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C3AC5A9AD2E624327B35872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A24209795067102C07E8F7B195E1C97831B4ED39C0913B0684AB73A7D1547457A7 X-C1DE0DAB: 0D63561A33F958A5C465C70AB5FD600454A59C44102A36F2A5B7771CBAAAA0B0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34181D1E89D5A0B42F679F830F3E57CC4F5D109BB6E56833DE9512637EB7AEF8B8E1C6FEAB355892891D7E09C32AA3244CAEA8258974DBA3EC99EAEA57132A2357A8CE788DE6831205FACE5A9C96DEB163 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojnA7/qPBUIXFhxc9su2zGzg== X-Mailru-Sender: 48EFD2E18A91C559803250E574CC3D29D70A936E609D07622F912B026F06E9EC21401CF93FD6FA55D35D514C7DAC97282D063C67CFD4E84987597EC79699C0E6F21BD4036121A32F7402F9BA4338D657ED14614B50AE0675 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH 0/3] Export curl symbols, enable smtp and install headers X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Leonid Vasiliev via Tarantool-patches Reply-To: Leonid Vasiliev Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Hi! Thank you for the patchset. Generally LGTM. See several commits below: 1) Add changelogs. 2) Have you checked the patch on some deb and rpm based distributions? On 3/19/21 5:13 PM, Roman Khabibov via Tarantool-patches wrote: > The patchset is for 1.10 only. > > Issue: https://github.com/tarantool/smtp/issues/24 > Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/curl-smtp_1_10 > > Roman Khabibov (3): > build: export libCURL symbols > build: enable smtp in libCURL > build: install libCURL headers > > CMakeLists.txt | 17 ++++ > cmake/BuildLibCURL.cmake | 2 +- > extra/curl_symbols | 81 ++++++++++++++++ > extra/mkexports | 14 ++- > rpm/tarantool.spec | 9 ++ > src/CMakeLists.txt | 5 +- > test/box-tap/curl-build.test.lua | 160 +++++++++++++++++++++++++++++++ > 7 files changed, 282 insertions(+), 6 deletions(-) > create mode 100755 extra/curl_symbols > create mode 100755 test/box-tap/curl-build.test.lua >