From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id ACB836EC5D; Mon, 5 Apr 2021 19:05:15 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org ACB836EC5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1617638715; bh=V9ig9h7ltCrXcdJKhZSy6J1t9MXVkbzpjSLwEGA3+Tc=; h=To:References:Date:In-Reply-To:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=CFWYKokzDpRAdcnXB0xuHZqNgE/UkJ/jiXbF3oK5Vum3DDa1PvKu6W8K8c8P4iBX+ BMRc/Dg/bT4A2lvJFVqNZrKtoZ+Nej7wozoJF88gms8BfiUUECae20SkIR66UIhbf5 XKrm7yOdUUfEJHyCv/L1fBijc96GfXh8V3ffuXgw= Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C687E6EC5D for ; Mon, 5 Apr 2021 19:05:00 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org C687E6EC5D Received: by smtpng3.m.smailru.net with esmtpa (envelope-from ) id 1lTRil-0002mI-R8; Mon, 05 Apr 2021 19:05:00 +0300 To: Cyrill Gorcunov , tml References: <20210402123420.885834-1-gorcunov@gmail.com> <20210402123420.885834-8-gorcunov@gmail.com> Message-ID: <8d4fcbb0-7120-8a9a-03fd-cf7495cd3183@tarantool.org> Date: Mon, 5 Apr 2021 18:04:58 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.9.0 MIME-Version: 1.0 In-Reply-To: <20210402123420.885834-8-gorcunov@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9ED7173E37F4E3294CA3588DDE0233B0D17711AF1EA2D7DB9182A05F5380850409C8A2DD61EF3E76A393BD23CB912492E512E19E1FFF75497FB2682C1103B7269 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7F8E53417176C7207EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006372A1456D053D20C618638F802B75D45FF914D58D5BE9E6BC131B5C99E7648C95C16EE06F5A270FE6AAFE57C1D087BD023F3E9DCC113663819A471835C12D1D9774AD6D5ED66289B5278DA827A17800CE70F3DDF2BBF19B93A9FA2833FD35BB23D2EF20D2F80756B5F868A13BD56FB6657A471835C12D1D977725E5C173C3A84C33B72D73EA5828B68117882F4460429728AD0CFFFB425014E868A13BD56FB6657E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F7900637553F28B1F14F2446EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-C1DE0DAB: 0D63561A33F958A51BF7BE99AD339F8EF345410A3183133B338E16C4693A5AD0D59269BC5F550898D99A6476B3ADF6B47008B74DF8BB9EF7333BD3B22AA88B938A852937E12ACA7502E6951B79FF9A3F410CA545F18667F91A7EA1CDA0B5A7A0 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34A63B03BCD35E0C0AE9D3853E892278702436DA0071658DD8A42BF2C9DF3BCE25DA8D93116A0876FA1D7E09C32AA3244CD4EEC6F83CCF972F08DA37D189C8C6913C6EB905E3A8056B927AC6DF5659F194 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojM00ve/f+0onC21dCXv/FyA== X-Mailru-Sender: 689FA8AB762F73936BC43F508A0638222CD3656599D7B494C2CD5990B9C209C83841015FED1DE5223CC9A89AB576DD93FB559BB5D741EB963CF37A108A312F5C27E8A8C3839CE0E267EA787935ED9F1B X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v20 7/7] test: add box.lib test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Vladislav Shpilevoy via Tarantool-patches Reply-To: Vladislav Shpilevoy Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" Thanks for the patch! Please, add tests for automatic garbage collection to ensure the modules and functions are unloaded. On 02.04.2021 14:34, Cyrill Gorcunov wrote: > Note that the test is disabled in suite.ini for a while > because we need to update test-run first like > > | diff --git a/pretest_clean.lua b/pretest_clean.lua > | index 446ecf2..b356ebd 100644 > | --- a/pretest_clean.lua > | +++ b/pretest_clean.lua > | @@ -228,6 +228,7 @@ local function clean() > | ['box.internal.sequence'] = true, > | ['box.internal.session'] = true, > | ['box.internal.space'] = true, > | + ['box.lib'] = true, > | buffer = true, > | clock = true, > | console = true, I think I already said it, but you could just make that patch in scope of your patchset. What are you waiting for?