From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <lvasiliev@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id F0FF5469719
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 16 Mar 2020 14:58:48 +0300 (MSK)
References: <cover.1573832434.git.lvasiliev@tarantool.org>
 <9edcf80e4a90667613e86beda1d98d44c1b9794b.1573832434.git.lvasiliev@tarantool.org>
 <bab829cb-45df-efee-8c62-45d3a903e24c@tarantool.org>
From: Leonid Vasiliev <lvasiliev@tarantool.org>
Message-ID: <8d2fd71d-fcf3-5653-7bf9-0420523ac3c7@tarantool.org>
Date: Mon, 16 Mar 2020 14:58:46 +0300
MIME-Version: 1.0
In-Reply-To: <bab829cb-45df-efee-8c62-45d3a903e24c@tarantool.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH 1/2] luarocks: add a kludge for
 option all of luarocks search
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, alexander.turenko@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

Hi. Thanks for the review!

On 3/15/20 8:54 PM, Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> Please, provide a more detailed message of what and why was
> done, exactly. And how to test it. And a docbot request, if
> you change any publicly visible behaviour of a documented
> module.

Behavior has't been changed, just fixed.

> 
> All the same for the second patch. If you will add a docbot
> request, it is enough to make one for two commits.
> 
> Also, please, rebase the branch on the latest master.
> 

Done. See V2

> See 2 comments below.
> 
> On 15/11/2019 16:44, Leonid wrote:
>> ---
>>   extra/dist/tarantoolctl.in | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/extra/dist/tarantoolctl.in b/extra/dist/tarantoolctl.in
>> index 6daf866ac..09302ea9c 100755
>> --- a/extra/dist/tarantoolctl.in
>> +++ b/extra/dist/tarantoolctl.in
>> @@ -937,6 +937,7 @@ local function rocks()
>>       local util = require("luarocks.util")
>>       local command_line = require("luarocks.cmd")
>>       local options = keyword_arguments
>> +
> 
> 1. Please, don't do stray changes not related to the issues.
> 
>>       local key = nil
>>       if options["only-server"] ~= nil then
>>           key = find_arg("only%-server")
>> @@ -945,6 +946,10 @@ local function rocks()
>>       end
>>       table.insert(positional_arguments, key)
>>   
>> +    if positional_arguments[1] == "search" and  find_arg("all") then
> 
> 2. Double whitespace after 'and'. The same in the next patch.
> 
>> +        table.insert(positional_arguments, "--all")
>> +    end
>> +
>>       -- Tweak help messages
>>       util.see_help = function(command, program)
>>           -- TODO: print extended help message here
>> @@ -1400,6 +1405,7 @@ local function populate_arguments()
>>           { 'only-server', 'string'  },
>>           { 'server',      'string'  },
>>           { 'language',    'string'  },
>> +        { 'all',         'boolean' },
>>       })
>>   
>>       local cmd_name
>>