From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id A5839173747A; Thu, 12 Feb 2026 16:26:42 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A5839173747A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1770902802; bh=mOGPS/JOaoi9uo/Fa6E9QKEydpeLBNFe4j3lUhjzP+E=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=X09ViacA8IeaXGYx1CfNQL+z/HWwEFYdntq0nBWOX/+uBE40TNfoZz65nwYEpPS8V t1wVuS1GMxvh6G/Was7APYcnC65Cp6z5xVBbGtVvEf+XMca4ybvLB/q9appUEaMcUf PfJ1G3XQYgoV/3LrYc4YWZKDyFc8fANOGe0/FwVQ= Received: from send34.i.mail.ru (send34.i.mail.ru [89.221.237.129]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1B4BB3952C0 for ; Thu, 12 Feb 2026 16:26:41 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B4BB3952C0 Received: by exim-smtp-5d446c7b8f-dvtmp with esmtpa (envelope-from ) id 1vqWiN-000000003hv-45AW; Thu, 12 Feb 2026 16:26:40 +0300 Content-Type: multipart/alternative; boundary="------------M3qCYclqfRTSbQ8196cJPjXd" Message-ID: <8d03ef1a-8456-45c8-a81d-b77009f1c27c@tarantool.org> Date: Thu, 12 Feb 2026 16:26:38 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org References: <501e08d75b66efe4221def8226d5b43820cc8490.1765350224.git.sergeyb@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD9A6EFB945BF0DEAB225376D8F438FA12D0920F60064AF0B28182A05F5380850408117CB26553D95DC3DE06ABAFEAF670590A5414754E471523DBCDEE8A590E47E242CE91CCB49B96E X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637AC83A81C8FD4AD23D82A6BABE6F325AC2E85FA5F3EDFCBAA7353EFBB553375664C71A6A4846DE5213F0F29037930DE822CAA98832CCCE50FED3BF9D7344567FF389733CBF5DBD5E913377AFFFEAFD269176DF2183F8FC7C04CF195F1528592878941B15DA834481FCF19DD082D7633A0EF3E4896CB9E6436389733CBF5DBD5E9D5E8D9A59859A8B6BAA8CD687FCDB2EBCC7F00164DA146DA6F5DAA56C3B73B237318B6A418E8EAB86D1867E19FE14079C09775C1D3CA48CF3D321E7403792E342EB15956EA79C166A417C69337E82CC275ECD9A6C639B01B78DA827A17800CE71DA2B2EB4F8B0219731C566533BA786AA5CC5B56E945C8DA X-C1DE0DAB: 0D63561A33F958A546D2263FFFBA81675002B1117B3ED69687CA05CB073499531A1B8FE1FED62FE8823CB91A9FED034534781492E4B8EEAD37F46C620FF2CAEEBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0AD73CAD6646DEDE1918E10F71CB4DF9F96AB70F9BE574AE9C625B6776AC983F447FC0B9F89525902EE6F57B2FD27647F25E66C117BDB76D65954FA49719FA74098940935B34FA8686B2C2DEF431175EA2ECC56C4286E69DC1F954ADD79AD4036B0B8341EE9D5BE9A0A18F460AB3FC3E92D18ED1B9340A0473BFDFAF72D3BB968936536EB022892E5344C41F94D744909CE2512F26BEC029E55448553D2254B8D95CD72808BE417F3B9E0E7457915DAA85F X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVemV+tRo3/+hZCtRIhHvAFQ= X-DA7885C5: 2938AE1A83756229F255D290C0D534F9D700BFA62F67455DBBDECC6FF25E557E7138EDC1AF11EBD05B1A4C17EAA7BC4BEF2421ABFA55128DAF83EF9164C44C7E X-Mailru-Sender: 689FA8AB762F7393DDD5FD59B456EAD2869A85F3EB97CA99373A967E72D281C4A578EBF1340BE397EF86D5F70DA33880E41E8EF7A07863ECB274557F927329BE2DDF8182D28ACDB545BD1C3CC395C826B4A721A3011E896F X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 1/3] MIPS64: Fix xpcall() error case. X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------M3qCYclqfRTSbQ8196cJPjXd Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi, Sergey, thanks for long-awaited review! On 2/11/26 10:17, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, with minor nits. > > On 10.12.25, Sergey Bronnikov wrote: >> From: Mike Pall >> >> Thanks to François Perrad and Stefan Pejic. >> >> (cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3) >> >> The patch fixes `xpcall()` segfaults on MIPS64 commit. The similar > Typo: s/commit/architecture/ Fixed. >> patch for ARM64 has been backported previously, see the commit > Minor: s/backported previously/backported (with the test) previously/ Fixed as well. Updated commit message: commit b5a84d2ba13df4d48c8ba46ee41a93f17dc00782 (HEAD) Author: Mike Pall Date:   Sat Nov 18 12:25:35 2017 +0100     MIPS64: Fix xpcall() error case.     Thanks to François Perrad and Stefan Pejic.     (cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)     The patch fixes `xpcall()` segfaults on MIPS64 architecture.     The similar patch for ARM64 has been backported (with the test)     previously, see the commit af889e4608e6eca495dd85e6161d8bcd7d3628e6     ("ARM64: Fix xpcall() error case (really).").     Sergey Bronnikov:     * added the description     Part of tarantool/tarantool#12134 > >> af889e4608e6eca495dd85e6161d8bcd7d3628e6 ("ARM64: Fix xpcall() >> error case (really)."). >> >> Sergey Bronnikov: >> * added the description >> >> Part of tarantool/tarantool#12134 >> --- > > --------------M3qCYclqfRTSbQ8196cJPjXd Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

Hi, Sergey,

thanks for long-awaited review!

On 2/11/26 10:17, Sergey Kaplun via Tarantool-patches wrote:
Hi, Sergey!
Thanks for the patch!
LGTM, with minor nits.

On 10.12.25, Sergey Bronnikov wrote:
From: Mike Pall <mike>

Thanks to François Perrad and Stefan Pejic.

(cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)

The patch fixes `xpcall()` segfaults on MIPS64 commit. The similar
Typo: s/commit/architecture/

Fixed.



      
patch for ARM64 has been backported previously, see the commit
Minor: s/backported previously/backported (with the test) previously/

Fixed as well.

Updated commit message:

commit b5a84d2ba13df4d48c8ba46ee41a93f17dc00782 (HEAD)
Author: Mike Pall <mike>
Date:   Sat Nov 18 12:25:35 2017 +0100

    MIPS64: Fix xpcall() error case.
    
    Thanks to François Perrad and Stefan Pejic.
    
    (cherry picked from commit ea7071d3c30b6432bfe6f8a9d263e0285cec25e3)
    
    The patch fixes `xpcall()` segfaults on MIPS64 architecture.
    The similar patch for ARM64 has been backported (with the test)
    previously, see the commit af889e4608e6eca495dd85e6161d8bcd7d3628e6
    ("ARM64: Fix xpcall() error case (really).").
    
    Sergey Bronnikov:
    * added the description
    
    Part of tarantool/tarantool#12134


af889e4608e6eca495dd85e6161d8bcd7d3628e6 ("ARM64: Fix xpcall()
error case (really).").

Sergey Bronnikov:
* added the description

Part of tarantool/tarantool#12134
---
<snipped>

--------------M3qCYclqfRTSbQ8196cJPjXd--