From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 91AA415D1123; Mon, 17 Nov 2025 17:11:34 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 91AA415D1123 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1763388694; bh=CM6wI8LkMbcnMfp2bTnEJcpebUD7jAzf6PkuaNbAHjU=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=JZzar2H1Ras6M1LUXyWVgPzozkPcjqcHdlzw5pZk0jLGdKxdy/20MzdXWg/8u6Tev ilzGdnWAcAoxqWGMdXEMWZP8QSa+aLli0eJPVgYyygJG3JaPanId4OJJb8iL3WYDCJ XEdDPPzb6s4mJGyn/Clv/X4lA6A88xix4qM7QRo4= Received: from send195.i.mail.ru (send195.i.mail.ru [95.163.59.34]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 464DF15D1123 for ; Mon, 17 Nov 2025 17:11:33 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 464DF15D1123 Received: by exim-smtp-88cf54d45-wb8vh with esmtpa (envelope-from ) id 1vKzx6-000000006kW-1V8I; Mon, 17 Nov 2025 17:11:32 +0300 Content-Type: multipart/alternative; boundary="------------7LH6ON03amQxa28jhfLfRhPG" Message-ID: <8cbe860e-f4cd-429d-ad1c-525dba098267@tarantool.org> Date: Mon, 17 Nov 2025 17:11:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun Cc: tarantool-patches@dev.tarantool.org References: <87afc15c5d756e28e21576c932c5742809cd5a0a.1761301736.git.skaplun@tarantool.org> In-Reply-To: <87afc15c5d756e28e21576c932c5742809cd5a0a.1761301736.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9110BAFCBE6BD1D16B955D557669B9266277B9011FC74A41D182A05F5380850405778B9BC766DA44A3DE06ABAFEAF6705C3DF8E13F17D0F3361C9E0771A6A769C9E051FE4FC7992BA X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7260723E369DE2609EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B5932F77F0041FFB8638F802B75D45FF914D58D5BE9E6BC1A93B80C6DEB9DEE97C6FB206A91F05B253EC15C098ADE6F32E070BE324C7D3C43CA726B5F7A21ABEF6B57BC7E64490618DEB871D839B73339E8FC8737B5C22494854413538E1713FCC7F00164DA146DAFE8445B8C89999729449624AB7ADAF37F6B57BC7E64490611E7FA7ABCAF51C92176DF2183F8FC7C078FCF50C7EAF9C588941B15DA834481F9449624AB7ADAF37BA3038C0950A5D3613377AFFFEAFD269176DF2183F8FC7C0FEA73F50E9734B707B076A6E789B0E97A8DF7F3B2552694AD5FFEEA1DED7F25D49FD398EE364050F9647ADFADE5905B1FCB1554B277F7060B3661434B16C20ACC84D3B47A649675FE827F84554CEF5019E625A9149C048EE9ECD01F8117BC8BEE2021AF6380DFAD18AA50765F790063735872C767BF85DA227C277FBC8AE2E8B569F1129A2C6445075ECD9A6C639B01B4E70A05D1297E1BBCB5012B2E24CD356 X-C1DE0DAB: 0D63561A33F958A5D42DAE7391EC6BE75002B1117B3ED6964280F7870411F72BA13BD6A4B0E00B96823CB91A9FED034534781492E4B8EEADB1D70E2111C441FFBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34EE6683D9E546CC623C3AC11F2903D01D9924305D665B69593681FDB58CF1CC5B0F6ADCAF66A9C9C21D7E09C32AA3244C266F98B2ED150FB077DD89D51EBB7742AA982B02ECFFD486EA455F16B58544A2E30DDF7C44BCB90DA5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu53w8ahmwBjZKM/YPHZyZHvz5uv+WouB9+ObcCpyrx6l7KImUglyhkEat/+ysWwi0gdhEs0JGjl6ggRWTy1haxBpVdbIX1nthFXMZebaIdHP2ghjoIc/363UZI6Kf1ptIMVfFX+FmbwDW1PZdLqEaUCno= X-Mailru-Sender: 520A125C2F17F0B1A9638AD358559B59BB173F5A7083CD0A3DE06ABAFEAF6705C3DF8E13F17D0F33B7CBEF92542CD7C8795FA72BAB74744FC77752E0C033A69EA16A481184E8BB1C9B38E6EA4F046BE03A5DB60FBEB33A8A0DA7A0AF5A3A8387 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v1 luajit 32/41] perf: adjust scimark-sor in LuaJIT-benches X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------7LH6ON03amQxa28jhfLfRhPG Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey, thanks for the patch! LGTM with a minor comment. Please add a small test description to the comment. Sergey On 10/24/25 13:50, Sergey Kaplun wrote: > This patch adjusts the aforementioned test to use the benchmark > framework introduced before. The default arguments are adjusted > according to the file. The arguments to the script still > can be provided in the command line run. > > Checks are omitted since they were not present in the original suite, > plus the precise result value depends on the input parameter. > --- > perf/LuaJIT-benches/scimark-sor.lua | 20 +++++++++++++++++++- > 1 file changed, 19 insertions(+), 1 deletion(-) > > diff --git a/perf/LuaJIT-benches/scimark-sor.lua b/perf/LuaJIT-benches/scimark-sor.lua > index e537e986..9bcdb0ad 100644 > --- a/perf/LuaJIT-benches/scimark-sor.lua > +++ b/perf/LuaJIT-benches/scimark-sor.lua > @@ -1 +1,19 @@ > -require("scimark_lib").SOR(100)(tonumber(arg and arg[1]) or 50000) > +local bench = require("bench").new(arg) > + > +local cycles = tonumber(arg and arg[1]) or 50000 > + > +local benchmark > +benchmark = { > + name = "scimark_sor", > + -- XXX: The description of tests for the function is too > + -- inconvenient. > + skip_check = true, > + payload = function() > + local flops = require("scimark_lib").SOR(100)(cycles) > + benchmark.items = flops > + end, > +} > + > +bench:add(benchmark) > + > +bench:run_and_report() --------------7LH6ON03amQxa28jhfLfRhPG Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey,

thanks for the patch! LGTM with a minor comment.

Please add a small test description to the comment.

Sergey

On 10/24/25 13:50, Sergey Kaplun wrote:
This patch adjusts the aforementioned test to use the benchmark
framework introduced before. The default arguments are adjusted
according to the <PARAM_x86.txt> file. The arguments to the script still
can be provided in the command line run.

Checks are omitted since they were not present in the original suite,
plus the precise result value depends on the input parameter.
---
 perf/LuaJIT-benches/scimark-sor.lua | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/perf/LuaJIT-benches/scimark-sor.lua b/perf/LuaJIT-benches/scimark-sor.lua
index e537e986..9bcdb0ad 100644
--- a/perf/LuaJIT-benches/scimark-sor.lua
+++ b/perf/LuaJIT-benches/scimark-sor.lua
@@ -1 +1,19 @@
-require("scimark_lib").SOR(100)(tonumber(arg and arg[1]) or 50000)
+local bench = require("bench").new(arg)
+
+local cycles = tonumber(arg and arg[1]) or 50000
+
+local benchmark
+benchmark = {
+  name = "scimark_sor",
+  -- XXX: The description of tests for the function is too
+  -- inconvenient.
+  skip_check = true,
+  payload = function()
+    local flops = require("scimark_lib").SOR(100)(cycles)
+    benchmark.items = flops
+  end,
+}
+
+bench:add(benchmark)
+
+bench:run_and_report()
--------------7LH6ON03amQxa28jhfLfRhPG--