From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <olegrok@tarantool.org>
Received: from smtp45.i.mail.ru (smtp45.i.mail.ru [94.100.177.105])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id B5814469711
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 28 May 2020 13:37:05 +0300 (MSK)
From: Oleg Babin <olegrok@tarantool.org>
References: <20200528100738.221911-1-gorcunov@gmail.com>
 <20200528100738.221911-3-gorcunov@gmail.com>
Message-ID: <8c51dc74-e403-4c46-a8b7-c2e371c15063@tarantool.org>
Date: Thu, 28 May 2020 13:37:04 +0300
MIME-Version: 1.0
In-Reply-To: <20200528100738.221911-3-gorcunov@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Subject: Re: [Tarantool-patches] [PATCH v4 2/8] lua/log: declare
 say_logger_init and say_logger_initialized
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>, tml <tarantool-patches@dev.tarantool.org>

Hi! Thanks for your patch. LGTM.

On 28/05/2020 13:07, Cyrill Gorcunov wrote:
> We gonna use it to provide a way to initialize
> logger subsystem early.
> 
> Part-of #689
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>   src/lua/log.lua | 8 ++++++++
>   1 file changed, 8 insertions(+)
> 
> diff --git a/src/lua/log.lua b/src/lua/log.lua
> index 312c14d5e..9830b0886 100644
> --- a/src/lua/log.lua
> +++ b/src/lua/log.lua
> @@ -1,5 +1,7 @@
>   -- log.lua
>   --
> +-- vim: ts=4 sw=4 et
> +
>   local ffi = require('ffi')
>   ffi.cdef[[
>       typedef void (*sayfunc_t)(int level, const char *filename, int line,
> @@ -22,6 +24,12 @@ ffi.cdef[[
>       void
>       say_set_log_format(enum say_format format);
>   
> +    extern void
> +    say_logger_init(const char *init_str, int level, int nonblock,
> +                    const char *format, int background);
> +
> +    extern bool
> +    say_logger_initialized(void);
>   
>       extern sayfunc_t _say;
>       extern struct ev_loop;
>