From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id E72E9F3295D; Tue, 11 Feb 2025 11:21:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E72E9F3295D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1739262092; bh=5bX9KlSgsjfPggH1e8cZ61xHJZd4K46kf8mzqH2RFdc=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=kq6uyS9/Mn4XLY06+aL6H57ClR3Eu+RhfG3I1f2RQfy4gwY3yRV58APvFQRhdj9Qy MHUL5n5OaNzplH6N3epSrIM8VzodMMIPa3cEGGX6cSgjnUaDiyM8SbjmWeDKOMBLnl tV/WQUiZdR5MfX58eMpi7dI9rx/wOwx2neR5VSWg= Received: from send37.i.mail.ru (send37.i.mail.ru [89.221.237.132]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9C322F32961 for ; Tue, 11 Feb 2025 11:21:30 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 9C322F32961 Received: by exim-smtp-5c664d6544-cm2d5 with esmtpa (envelope-from ) id 1thlWG-00000000J6S-1n7E; Tue, 11 Feb 2025 11:21:24 +0300 Content-Type: multipart/alternative; boundary="------------qOMoXnFW1XX84adScYfRusSz" Message-ID: <8bdba01f-846d-4e84-a692-f1b25332bcd1@tarantool.org> Date: Tue, 11 Feb 2025 11:21:23 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Sergey Bronnikov Cc: tarantool-patches@dev.tarantool.org References: <6ff0d573c1bc2302729c6c7e3b62a264f413b4f0.1738663201.git.sergeyb@tarantool.org> In-Reply-To: X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: B8F34718100C35BD X-77F55803: 4F1203BC0FB41BD980EDB4062763125EA87B7F9825D8BCB1735AC7CB101CCC1600894C459B0CD1B9CC7F33DC9E57A9A58E7FD94675F335652012A516A12583771534ACAA4CB4C0E7B57612C3CDEB6A40 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7A8325FA649D0A450EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637B05885A782BE20C5EA1F7E6F0F101C6723150C8DA25C47586E58E00D9D99D84E1BDDB23E98D2D38BC08E230531AC9C90A7DD8EC57524DB50F1BA6A7EC0E91C8A8AD0F10251432666A471835C12D1D9774AD6D5ED66289B5259CC434672EE6371117882F4460429724CE54428C33FAD30A8DF7F3B2552694AC26CFBAC0749D213D2E47CDBA5A9658378DA827A17800CE7328B01A8D746D8839FA2833FD35BB23DF004C90652538430302FCEF25BFAB3454AD6D5ED66289B5278DA827A17800CE7622A29705F065304D32BA5DBAC0009BE395957E7521B51C2330BD67F2E7D9AF1090A508E0FED6299176DF2183F8FC7C061CD53100284B95BCD04E86FAF290E2DB606B96278B59C421DD303D21008E29813377AFFFEAFD269A417C69337E82CC2E827F84554CEF50127C277FBC8AE2E8BA83251EDC214901ED5E8D9A59859A8B658CDF7FFE3EBBCC0089D37D7C0E48F6C5571747095F342E88FB05168BE4CE3AF X-C1DE0DAB: 0D63561A33F958A51572CEC00295CF685002B1117B3ED69642EBC8673A91474FE772F934B9BCD185823CB91A9FED034534781492E4B8EEAD0AA277257C6A5E3DBDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADBF74143AD284FC7177DD89D51EBB7742424CF958EAFF5D571004E42C50DC4CA955A7F0CF078B5EC49A30900B95165D34B3611847B8BC2D0BC5AE801AA82F071D983EF22DCA6BC7F79C16A0996EE3056B891AB5F94816CEF91D7E09C32AA3244C9EDB68F3B371BB0577DD89D51EBB7742F21F62AE4D486F8BEA455F16B58544A2557BDE0DD54B3590A5AE236DF995FB59978A700BF655EAEEED6A17656DB59BCAD427812AF56FC65B X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2bioj4p5EDZXZmhEWzt7STI7lMA== X-Mailru-Sender: C4F68CFF4024C8867DFDF7C7F25884581D6BF81A4DC1ABA291CF6C6A8F7D6EF63480C9E4637CB2BEB4BA7C49DB962819645D15D82EE4B272BD6E4642A116CA93524AA66B5ACBE6721EF430B9A63E2A504198E0F3ECE9B5443453F38A29522196 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH luajit 2/4] sysprof: fix typo in the comment X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------qOMoXnFW1XX84adScYfRusSz Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi, Sergey! thanks for review! Fixed and force-pushed. On 10.02.2025 17:51, Sergey Kaplun via Tarantool-patches wrote: > Hi, Sergey! > Thanks for the patch! > LGTM, with a few nits below regarding the commit message. > > On 04.02.25, Sergey Bronnikov wrote: >> The patch fixes inconsistency in comment and source code below >> the comment. The typo was added in the initial commit >> 2593a9f83072 ("misc: introduce Lua API for new sampling profiler"). > Please use the full commit hash. Fixed. > > I know that this is enough too, but: > a) It would be consistent with other commit messages. > b) There is less probability of the collision between hashes. > > Maybe it is worth to mention "Follows up tarantool/tarantool#781" (the > sysprof ticket) if you want (I am not sure that this is needed, since it > is only the comment). Added. >> --- >> src/lib_misc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/lib_misc.c b/src/lib_misc.c >> index ca1d1c75..5b7a4b62 100644 >> --- a/src/lib_misc.c >> +++ b/src/lib_misc.c > > >> -- >> 2.34.1 >> --------------qOMoXnFW1XX84adScYfRusSz Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Hi, Sergey!

thanks for review! Fixed and force-pushed.

On 10.02.2025 17:51, Sergey Kaplun via Tarantool-patches wrote:
Hi, Sergey!
Thanks for the patch!
LGTM, with a few nits below regarding the commit message.

On 04.02.25, Sergey Bronnikov wrote:

The patch fixes inconsistency in comment and source code below
the comment. The typo was added in the initial commit
2593a9f83072 ("misc: introduce Lua API for new sampling profiler").

Please use the full commit hash.
Fixed.

I know that this is enough too, but:
a) It would be consistent with other commit messages.
b) There is less probability of the collision between hashes.

Maybe it is worth to mention "Follows up tarantool/tarantool#781" (the
sysprof ticket) if you want (I am not sure that this is needed, since it
is only the comment).
Added.

      

        
---
 src/lib_misc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib_misc.c b/src/lib_misc.c
index ca1d1c75..5b7a4b62 100644
--- a/src/lib_misc.c
+++ b/src/lib_misc.c


      

      
<snipped>



      

        
-- 
2.34.1



      

      

    

  
  


--------------qOMoXnFW1XX84adScYfRusSz--