From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id CB69227255 for ; Tue, 17 Jul 2018 08:03:57 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rgQ0Rt_nSE0Q for ; Tue, 17 Jul 2018 08:03:57 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 7D79726DA7 for ; Tue, 17 Jul 2018 08:03:57 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v1 1/1] lua: fix strange behaviour of tonumber64 References: <6b638fd3-58bc-2ed7-c32c-3f0a440d1f2b@tarantool.org> <20180716124949.3uhj5zrkivphdnaw@tkn_work_nb> <20180716134210.zp3tckp3gcgchm4q@tkn_work_nb> <56a17552-ddcf-08cd-3ce1-78018f9dc748@tarantool.org> <20180716140907.62lazzvz4vx2e7fz@tkn_work_nb> <58f21346-5ae1-97fe-2231-0d86f3c9717f@tarantool.org> <8b7eb4a3-3aec-a63c-034e-fd0ace55d0d9@tarantool.org> <20180717112746.mh2cqq22acw4mtsu@tkn_work_nb> From: Kirill Shcherbatov Message-ID: <8bda0436-9681-5662-9f51-927cbf26fbae@tarantool.org> Date: Tue, 17 Jul 2018 15:03:53 +0300 MIME-Version: 1.0 In-Reply-To: <20180717112746.mh2cqq22acw4mtsu@tkn_work_nb> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-subscribe: List-owner: List-post: List-archive: To: tarantool-patches@freelists.org, Vladislav Shpilevoy , Alexander Turenko >>> +-- gh-3466: Strange behaviour of tonumber64 function >>> +-- >>> +tostring(tonumber64('18446744073709551615')) == '18446744073709551615ULL' >>> +tonumber64('18446744073709551616') == nil >> 2. Where is a test for another corner case? I mean INT64_MAX. Actually, the max value is not INT64_MAX; but UINT64_MAX that is tested above. But I don't mind to add INT64_MAX test. +tostring(tonumber64('9223372036854775807')) == '9223372036854775807ULL' > I also propose to test zero. +tostring(tonumber64('0')) == '0' > 1. Please, add a comment about the things we have discussed as Alexander asked > in the previous message. + /* + * To test overflow, consider + * result > -INT64_MIN; + * result - 1 > -INT64_MIN - 1; + * Assumption: + * INT64_MAX == -(INT64_MIN + 1); + * Finally, + * result - 1 > INT64_MAX; + */