From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTP id DE91324FE9 for ; Thu, 11 Jul 2019 03:40:03 -0400 (EDT) Received: from turing.freelists.org ([127.0.0.1]) by localhost (turing.freelists.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eQs27J4hnhBI for ; Thu, 11 Jul 2019 03:40:03 -0400 (EDT) Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by turing.freelists.org (Avenir Technologies Mail Multiplex) with ESMTPS id 9764C20D2F for ; Thu, 11 Jul 2019 03:40:03 -0400 (EDT) Subject: [tarantool-patches] Re: [PATCH v2 08/12] sql: rfc for SQL and Lua functions References: <53e0ef51750696b33729dfcb38a269f1ee159112.1562756438.git.kshcherbatov@tarantool.org> <20190710191705.GI5619@atlas> <20190710191811.GJ5619@atlas> From: Kirill Shcherbatov Message-ID: <8bc802de-06cd-0ec4-1441-fe55343de6f2@tarantool.org> Date: Thu, 11 Jul 2019 10:40:00 +0300 MIME-Version: 1.0 In-Reply-To: <20190710191811.GJ5619@atlas> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: tarantool-patches-bounce@freelists.org Errors-to: tarantool-patches-bounce@freelists.org Reply-To: tarantool-patches@freelists.org List-Help: List-Unsubscribe: List-software: Ecartis version 1.0.0 List-Id: tarantool-patches List-Subscribe: List-Owner: List-post: List-Archive: To: tarantool-patches@freelists.org, Kostya Osipov , Nikita Pettik >> The spec generally looks good to me, but I don't see how you >> addressed the case sensitivity issue. Please add name_ucase field >> to the _func definition, and add a unique index over it, to >> prevent duplicates with a differently cased name. > > Sorry, forget this. Hit "send" too hastily. I noticed that you > changed the unique index collation on "name" to case insensitive. > Please mention this in the spec, I missed that at first. After > that the spec is OK to push. There was a string: "We must forbid such names for `box.schema.func.create` endpoint to prevent a mess in SQL code. To solve this problem, we may set `collation = 'unicode_ci'` for ``_func.name`` field and put all built-ins in bootstrap image." in RFC already.