From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <v.shpilevoy@tarantool.org>
Subject: Re: [tarantool-patches] Re: [PATCH 01/11] box: move info_handler
 interface into src/info
References: <cover.1543590433.git.v.shpilevoy@tarantool.org>
 <265787a088a3b0625966ee726c16831e5cc877e4.1543590433.git.v.shpilevoy@tarantool.org>
 <20181203204127.GJ2890@chai>
From: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Message-ID: <8bc2943a-26ed-25b6-9754-cc9da763629b@tarantool.org>
Date: Tue, 4 Dec 2018 00:48:25 +0300
MIME-Version: 1.0
In-Reply-To: <20181203204127.GJ2890@chai>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
To: tarantool-patches@freelists.org, Konstantin Osipov <kostja@tarantool.org>
Cc: vdavydov.dev@gmail.com
List-ID: <tarantool-patches.dev.tarantool.org>

Hi! Thanks for the review!

On 03/12/2018 23:41, Konstantin Osipov wrote:
> * Vladislav Shpilevoy <v.shpilevoy@tarantool.org> [18/11/30 18:41]:
>> @@ -30,10 +30,10 @@
>>    */
>>   #include "box/lua/index.h"
>>   #include "lua/utils.h"
>> +#include "lua/info.h"
>> +#include <info.h>
> 
> Please prefer local headers whenever you can ("" rather than <>).
> Your host platform can have a header file info.h at a system-wide
> location. It's easy if it simply breaks your compile in a funny
> way. Worse if it doesn't break.

Look at my answer to Vova.

> 
>> +++ b/src/box/lua/info.c
>> @@ -32,7 +32,7 @@
>>   #define _GNU_SOURCE
>>   #endif
> 
> Since you are up to cleaning things up a bit, please get rid of
> file-local _GNU_SOURCE. It should be part of cmake compile flags
> for this file.

Unfortunately, Vova required to remove all my cleanup so
I can not remove _GNU_SOURCE in scope of this patch, sorry.