From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 459F3C5B3DD; Thu, 22 Aug 2024 18:05:31 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 459F3C5B3DD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724339131; bh=oK2AnyGDpFq9f1YL1eYx53OBc4hw2qW0mto4usCTh1E=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=nJqjeCDVpSljaoBofaS7mJta2o+RoNfOAuQey1Qcqn0Wdm1t/I9ZUdyJI4WhoLUIM F/AIAGKYvSyoxyyXZEmx2jMUa8WoccPNHXd5c3p66xGfCGt6/yYBnxK5+uILsUJvBh +j6dOooo32cyPilgWTQ99A0pTlT0vUYFg3/v+Msc= Received: from smtp33.i.mail.ru (smtp33.i.mail.ru [95.163.41.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A1FB9C5B3DC for ; Thu, 22 Aug 2024 18:05:28 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org A1FB9C5B3DC Received: by smtp33.i.mail.ru with esmtpa (envelope-from ) id 1sh9NQ-0000000919k-0XRd; Thu, 22 Aug 2024 18:05:28 +0300 Content-Type: multipart/alternative; boundary="------------EtU7wyPeKPQkU1yFGwE4AO2x" Message-ID: <8ac816ae-37c8-402b-a054-feac3d1214d3@tarantool.org> Date: Thu, 22 Aug 2024 18:05:27 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <99ca67ea2ea8e41904475477631ce3a01f05241a.1724228998.git.skaplun@tarantool.org> In-Reply-To: <99ca67ea2ea8e41904475477631ce3a01f05241a.1724228998.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD9A67092BE052B1D9E80479E83A5F5ECBC2B3CE5FDEE63E974182A05F538085040FCC82BA41A40F4875D1BE6A8D71B10A54A38FC11A2C001C1EDDFFFF196D306A599950209BA47E511 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7AED985C8E545F588EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F7900637CF20B9B7F5DD35A68638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D84C0F65B56DB24309D254BBB05AAC4AD0E4177C68E653AF09CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F7900637F3E38EE449E3E2AE389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F7900637B3B881E57936E120D81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7E8EDC39F4C7E04DDEC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C30A3B31C63366F72535872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A548A0104DA412EBB85002B1117B3ED696A0EE0A360178D1AD0E58516B1639A14B823CB91A9FED034534781492E4B8EEAD85CCBA673D36D1A4BDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CFDE07BFBD02CF91BA7F02DD5515CDA6E42D82EE3CB21AD5DD8E93B3722E0191032B6ADA43BC89BCA92FB0CAD32ADFBF84C6DD7646CDA661E6A5EFB56496C9CFCEC69F4C29A829F1785F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XoZXa7UqwhsSw== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D6140560B581BE5C3565FA1FB965E4AF8A5C1D970EB3E4E0DA9730152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 09/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------EtU7wyPeKPQkU1yFGwE4AO2x Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, On 21.08.2024 11:58, Sergey Kaplun wrote: > This patch refactors the aforementioned test to make its code style > closer to ours. > > Relates to tarantool/tarantool#9398 > --- thanks for the patch! LGTM > test/LuaJIT-tests/lang/dualnum.lua | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/test/LuaJIT-tests/lang/dualnum.lua b/test/LuaJIT-tests/lang/dualnum.lua > index d0b1e5d2..bc52b742 100644 > --- a/test/LuaJIT-tests/lang/dualnum.lua > +++ b/test/LuaJIT-tests/lang/dualnum.lua > @@ -2,31 +2,31 @@ > > do --- Positive overflow. > local x = 0 > - for i=2147483446,2147483647,2 do x = x + 1 end > + for _ = 2147483446, 2147483647, 2 do x = x + 1 end > assert(x == 101) > end > > do --- Negative overflow. > local x = 0 > - for i=-2147483447,-2147483648,-2 do x = x + 1 end > + for _ = -2147483447, -2147483648, -2 do x = x + 1 end > assert(x == 101) > end > > do --- SLOAD with number to integer conversion. > local k = 1 > local a, b, c = 1/k, 20/k, 1/k > - for i=1,20 do > - for j=a,b,c do end > + for _ = 1, 20 do > + for _ = a, b, c do end > end > end > > do --- min/max correctness. > local function fmin(a, b) > - for i=1,100 do a = math.min(a, b) end > + for _ = 1, 100 do a = math.min(a, b) end > return a > end > local function fmax(a, b) > - for i=1,100 do a = math.max(a, b) end > + for _ = 1, 100 do a = math.max(a, b) end > return a > end > assert(fmin(1, 3) == 1) --------------EtU7wyPeKPQkU1yFGwE4AO2x Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:
This patch refactors the aforementioned test to make its code style
closer to ours.

Relates to tarantool/tarantool#9398
---
thanks for the patch! LGTM 
 test/LuaJIT-tests/lang/dualnum.lua | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/test/LuaJIT-tests/lang/dualnum.lua b/test/LuaJIT-tests/lang/dualnum.lua
index d0b1e5d2..bc52b742 100644
--- a/test/LuaJIT-tests/lang/dualnum.lua
+++ b/test/LuaJIT-tests/lang/dualnum.lua
@@ -2,31 +2,31 @@
 
 do --- Positive overflow.
   local x = 0
-  for i=2147483446,2147483647,2 do x = x + 1 end
+  for _ = 2147483446, 2147483647, 2 do x = x + 1 end
   assert(x == 101)
 end
 
 do --- Negative overflow.
   local x = 0
-  for i=-2147483447,-2147483648,-2 do x = x + 1 end
+  for _ = -2147483447, -2147483648, -2 do x = x + 1 end
   assert(x == 101)
 end
 
 do --- SLOAD with number to integer conversion.
   local k = 1
   local a, b, c = 1/k, 20/k, 1/k
-  for i=1,20 do
-    for j=a,b,c do end
+  for _ = 1, 20 do
+    for _ = a, b, c do end
   end
 end
 
 do --- min/max correctness.
   local function fmin(a, b)
-    for i=1,100 do a = math.min(a, b) end
+    for _ = 1, 100 do a = math.min(a, b) end
     return a
   end
   local function fmax(a, b)
-    for i=1,100 do a = math.max(a, b) end
+    for _ = 1, 100 do a = math.max(a, b) end
     return a
   end
   assert(fmin(1, 3) == 1)
--------------EtU7wyPeKPQkU1yFGwE4AO2x--