From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [tarantool-patches] Re: [PATCH v9 5/6] box: introduce offset_slot cache in key_part References: <709ad0bac8976ed78bcf0ce418567b2e3a378a77.1549187339.git.kshcherbatov@tarantool.org> <20190204125603.yi3ybmvwif2pki6d@esperanza> From: Kirill Shcherbatov Message-ID: <8a94beee-5b07-ee76-c782-5c11ef6ce9b2@tarantool.org> Date: Mon, 4 Feb 2019 16:02:40 +0300 MIME-Version: 1.0 In-Reply-To: <20190204125603.yi3ybmvwif2pki6d@esperanza> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit To: tarantool-patches@freelists.org, Vladimir Davydov List-ID: > Can I move it above the call to tuple_format_create, where other > tuple_format fields are initialized? If format reuse is successful, the global variable for the epoch will be increased in vain. I wanted to avoid it. > Why? Can I remove it? If you are not concerned about the leak of this number, you can bear it before calling tuple_format_reuse.