From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 817CEF13961; Thu, 22 Aug 2024 17:53:10 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 817CEF13961 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1724338390; bh=0Wxv8SNqSiCdscceYFruLlgJUD7tqut/dICfIsZg1Fw=; h=Date:To:Cc:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=Pohl/ePH5ggdf37CZIRdMCeGWB3sBjQFnYcNV5Wpl9p2+2uCi1K+F83DUA4mp0L2z /nfMf9wjpTvftuMM/TkGKB8cJ9zl/SAWyqH03ccRHFZBu/+s9yVGUFWMY0XKFQw9UU 2FhqbMJbJAV4aQfi0I5Ds7Apeaw5elm46c4bZ+WA= Received: from smtp43.i.mail.ru (smtp43.i.mail.ru [95.163.41.66]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E1FC3F13956 for ; Thu, 22 Aug 2024 17:53:09 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org E1FC3F13956 Received: by smtp43.i.mail.ru with esmtpa (envelope-from ) id 1sh9BV-0000000B3NR-1IaQ; Thu, 22 Aug 2024 17:53:09 +0300 Content-Type: multipart/alternative; boundary="------------8Ru6HRg6yVB0b4U10UWjLwfm" Message-ID: <8a92c346-7529-4c65-8be0-875ba9fc59fe@tarantool.org> Date: Thu, 22 Aug 2024 17:53:08 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: Sergey Kaplun , Maxim Kokryashkin Cc: tarantool-patches@dev.tarantool.org References: <5f4e599660208fb8d5c5bcdcf3480bf2b6052dcf.1724228998.git.skaplun@tarantool.org> In-Reply-To: <5f4e599660208fb8d5c5bcdcf3480bf2b6052dcf.1724228998.git.skaplun@tarantool.org> X-Mailru-Src: smtp X-4EC0790: 10 X-7564579A: EEAE043A70213CC8 X-77F55803: 4F1203BC0FB41BD9604F665CF1C84C299E6D8E1CC684B50B3F077263C41BE8DD182A05F5380850404C228DA9ACA6FE27B38236A240C00B9633594132A326AF8B5B8E1797BCF7A29DD0B9F2342C1BD1893B74FEA2CA3DCB6F X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE71EAE3A63419E5AEDEA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F79006379A70878BADDF00B98638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8EEF5ED09AA4E6C44A44F025A57CA1C99DC228D36A19BC0F9CC7F00164DA146DAFE8445B8C89999728AA50765F7900637F6B57BC7E64490618DEB871D839B7333395957E7521B51C2DFABB839C843B9C08941B15DA834481F8AA50765F79006372A3B24BF85B2E607389733CBF5DBD5E9B5C8C57E37DE458BD9DD9810294C998ED8FC6C240DEA76428AA50765F79006376123584C0BA1C1EFD81D268191BDAD3DBD4B6F7A4D31EC0BE2F48590F00D11D6D81D268191BDAD3D78DA827A17800CE7C929ACAF0DB8D528EC76A7562686271ED91E3A1F190DE8FD2E808ACE2090B5E14AD6D5ED66289B5259CC434672EE63711DD303D21008E298D5E8D9A59859A8B6B372FE9A2E580EFC725E5C173C3A84C307FFBFDCC3B3F35035872C767BF85DA2F004C90652538430E4A6367B16DE6309 X-C1DE0DAB: 0D63561A33F958A5BCF4CBA7719CCC7D5002B1117B3ED696ABE304DF61A3FC4AB74D9144D44E4FCF823CB91A9FED034534781492E4B8EEAD09F854029C6BD0DABDAD6C7F3747799A X-C8649E89: 1C3962B70DF3F0ADE00A9FD3E00BEEDF3FED46C3ACD6F73ED3581295AF09D3DF87807E0823442EA2ED31085941D9CD0AF7F820E7B07EA4CF30E55C9C642389C4935149E9A053BD36A57E4FBDDB970769014C04EAFB9499D97622FCE73A124D832FB0CAD32ADFBF847E23963D9BDF039728D1C74689B708CD9330B30A8D57AE125F4332CA8FE04980913E6812662D5F2AB9AF64DB4688768036DF5FE9C0001AF333F2C28C22F508233FCF178C6DD14203 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbUwDRTee1XoaQlC2Wo5NVA== X-Mailru-Sender: 520A125C2F17F0B1E52FEF5D219D61405762E0A8E8CFF8CFC3C9541E35645214D95A06B1AB19F0830152A3D17938EB451EB5A0BCEC6A560B3DDE9B364B0DF289BE2DA36745F2EEB5CEBA01FB949A1F1EEAB4BC95F72C04283CDA0F3B3F5B9367 X-Mras: Ok Subject: Re: [Tarantool-patches] [PATCH v2 luajit 14/45] test: refactor LuaJIT test X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergey Bronnikov via Tarantool-patches Reply-To: Sergey Bronnikov Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" This is a multi-part message in MIME format. --------------8Ru6HRg6yVB0b4U10UWjLwfm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sergey, On 21.08.2024 11:58, Sergey Kaplun wrote: > This patch refactors the aforementioned test to make its code style > closer to ours. > > Relates to tarantool/tarantool#9398 > --- thanks for the patch! LGTM > test/LuaJIT-tests/trace/gc.lua | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/test/LuaJIT-tests/trace/gc.lua b/test/LuaJIT-tests/trace/gc.lua > index 43d7ae55..f6b40aac 100644 > --- a/test/LuaJIT-tests/trace/gc.lua > +++ b/test/LuaJIT-tests/trace/gc.lua > @@ -5,9 +5,9 @@ do --- Collect dead traces. > collectgarbage() > -- Prevent the creation of side traces. > jit.off() > - for j=1,100 do > + for _ = 1, 100 do > jit.on() > - loadstring("for i=1,100 do end")() > + loadstring("for _ = 1, 100 do end")() > jit.off() > end > jit.on() > @@ -29,7 +29,7 @@ do --- Check KGC marking. > end > end > jit.attach(reccb, "record") > - for i=1,200 do > + for i = 1, 200 do > if i % 5 == 0 then > f = function() end > elseif f then --------------8Ru6HRg6yVB0b4U10UWjLwfm Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit

Sergey,

On 21.08.2024 11:58, Sergey Kaplun wrote:
This patch refactors the aforementioned test to make its code style
closer to ours.

Relates to tarantool/tarantool#9398
---
thanks for the patch! LGTM 
 test/LuaJIT-tests/trace/gc.lua | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/test/LuaJIT-tests/trace/gc.lua b/test/LuaJIT-tests/trace/gc.lua
index 43d7ae55..f6b40aac 100644
--- a/test/LuaJIT-tests/trace/gc.lua
+++ b/test/LuaJIT-tests/trace/gc.lua
@@ -5,9 +5,9 @@ do --- Collect dead traces.
   collectgarbage()
   -- Prevent the creation of side traces.
   jit.off()
-  for j=1,100 do
+  for _ = 1, 100 do
     jit.on()
-    loadstring("for i=1,100 do end")()
+    loadstring("for _ = 1, 100 do end")()
     jit.off()
   end
   jit.on()
@@ -29,7 +29,7 @@ do --- Check KGC marking.
     end
   end
   jit.attach(reccb, "record")
-  for i=1,200 do
+  for i = 1, 200 do
     if i % 5 == 0 then
       f = function() end
     elseif f then
--------------8Ru6HRg6yVB0b4U10UWjLwfm--