From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from [87.239.111.99] (localhost [127.0.0.1]) by dev.tarantool.org (Postfix) with ESMTP id 961316EC43; Thu, 1 Jul 2021 23:26:45 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 961316EC43 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tarantool.org; s=dev; t=1625171205; bh=8uLQL3OkzpW0k8QWTUxRKhdyGgJwyIdv/1miGSaC268=; h=To:Date:In-Reply-To:References:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=QZa10A60SBFJGxFcsbeS+eds6ui/a9IiL0Q7aBQ4mdYIITPuVZF+52zi/34BZwo2D QizyzWYL1+M+3r7A/pxrMSXFTRztYJNHveJ2Wnws0g0CvOeNqGAHETJD0kDyjpcz2T bNb+mpZKdtPBAHf+S70z2cMuCcaBC/VQ/8U40T1s= Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 1B37E6EC44 for ; Thu, 1 Jul 2021 23:25:48 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 dev.tarantool.org 1B37E6EC44 Received: by smtp60.i.mail.ru with esmtpa (envelope-from ) id 1lz3Fq-0006gg-Qw; Thu, 01 Jul 2021 23:25:47 +0300 To: gorcunov@tarantool.org, alyapunov@tarantool.org, skaplun@tarantool.org Date: Thu, 1 Jul 2021 23:24:40 +0300 Message-Id: <8a5e79f37037ade3a4dbfa70bec2db96cce93a2f.1625170992.git.elchinov.es@gmail.com> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-7564579A: 646B95376F6C166E X-77F55803: 4F1203BC0FB41BD954DFF1DC42D673FB517E8D1A7E34673E94B235AA752823A6182A05F5380850401896F4279D517766A509601725532CF687C4A1A918B751061FEBF3B25A1258C7 X-7FA49CB5: FF5795518A3D127A4AD6D5ED66289B5278DA827A17800CE7FCFCB92DA8654BB0EA1F7E6F0F101C67BD4B6F7A4D31EC0BCC500DACC3FED6E28638F802B75D45FF8AA50765F790063707C4856229E8E7E48638F802B75D45FF36EB9D2243A4F8B5A6FCA7DBDB1FC311F39EFFDF887939037866D6147AF826D8704F7ECFF277339BE1EE8340F9BBF2E8117882F4460429724CE54428C33FAD305F5C1EE8F4F765FC974A882099E279BDA471835C12D1D9774AD6D5ED66289B52BA9C0B312567BB23117882F446042972877693876707352033AC447995A7AD182CC0D3CB04F14752D2E47CDBA5A96583BA9C0B312567BB2376E601842F6C81A19E625A9149C048EE7532CA1512B81981E21AE983DBD7FFC1D8FC6C240DEA7642DBF02ECDB25306B2B78CF848AE20165D0A6AB1C7CE11FEE30085B890FD2717DA302FCEF25BFAB345C4224003CC836476EA7A3FFF5B025636E2021AF6380DFAD1A18204E546F3947CB11811A4A51E3B096D1867E19FE1407959CC434672EE6371089D37D7C0E48F6C8AA50765F79006379FC65886B7F75608EFF80C71ABB335746BA297DBC24807EABDAD6C7F3747799A X-B7AD71C0: AC4F5C86D027EB782CDD5689AFBDA7A2368A440D3B0F6089093C9A16E5BC824A2A04A2ABAA09D25379311020FFC8D4ADD39CE08E0D58FA78A1BCE4AC83860CD6 X-C1DE0DAB: C20DE7B7AB408E4181F030C43753B8186998911F362727C414F749A5E30D975CBCA6440478D4BA46E0D6D0E48BB8CB168224F487396C93709C2B6934AE262D3EE7EAB7254005DCED7532B743992DF240BDC6A1CF3F042BAD6DF99611D93F60EFCCE3E035A672CDEE699F904B3F4130E343918A1A30D5E7FCCB5012B2E24CD356 X-C8649E89: 4E36BF7865823D7055A7F0CF078B5EC49A30900B95165D34C5CF6F4B28551E3FF63C5AC56FF97C231E30499076183FC1D74561E5FE867519FFCD35E8AD01915F1D7E09C32AA3244C6AB49A369E5F8E52F497F2C9A01AA670E8FBBEFAE1C4874C83B48618A63566E0 X-D57D3AED: 3ZO7eAau8CL7WIMRKs4sN3D3tLDjz0dLbV79QFUyzQ2Ujvy7cMT6pYYqY16iZVKkSc3dCLJ7zSJH7+u4VD18S7Vl4ZUrpaVfd2+vE6kuoey4m4VkSEu530nj6fImhcD4MUrOEAnl0W826KZ9Q+tr5ycPtXkTV4k65bRjmOUUP8cvGozZ33TWg5HZplvhhXbhDGzqmQDTd6OAevLeAnq3Ra9uf7zvY2zzsIhlcp/Y7m53TZgf2aB4JOg4gkr2biojbL9S8ysBdXhQbJZ+TAeEv70LjJHf0CXE X-Mailru-Sender: EFA0F3A8419EF2166B053C73E674FFD57639835838B9BB9E6488B511F530D7A4E2527C969975515C67F54F2D6EFFC80BC77752E0C033A69E17841C44D9B5D58765F2F89A5AFDB6F16C18EFA0BB12DBB0 X-Mras: Ok Subject: [Tarantool-patches] [PATCH 2/7] fiber: fix DARWIN build X-BeenThere: tarantool-patches@dev.tarantool.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Egor Elchinov via Tarantool-patches Reply-To: eelchinov@tarantool.org Cc: tarantool-patches@dev.tarantool.org Errors-To: tarantool-patches-bounces@dev.tarantool.org Sender: "Tarantool-patches" From: Egor Elchinov From: Egor Elchinov Due to the limited libunwind API under osx this fix uses backtrace() from and dladdr() from instead of absent libunwind routines. Custom backtrace() function was renamed to backtrace_to_buf() because of the name conflict with backtrace() routine from . Needed for: #4002 --- src/lib/core/backtrace.cc | 38 +++++++++++++++++++++++++++++++------- src/lib/core/backtrace.h | 2 +- src/lib/core/crash.c | 2 +- 3 files changed, 33 insertions(+), 9 deletions(-) diff --git a/src/lib/core/backtrace.cc b/src/lib/core/backtrace.cc index 276933ad6..a1727374c 100644 --- a/src/lib/core/backtrace.cc +++ b/src/lib/core/backtrace.cc @@ -46,6 +46,11 @@ #ifdef ENABLE_BACKTRACE #include +#ifdef TARGET_OS_DARWIN +#include +#include +#endif + #include "small/region.h" #include "small/static.h" /* @@ -131,7 +136,7 @@ error: } char * -backtrace(char *start, size_t size) +backtrace_to_buf(char *start, size_t size) { int frame_no = 0; unw_word_t sp = 0, old_sp = 0, ip, offset; @@ -442,7 +447,11 @@ void fast_trace_collect(void **ip_buf, int limit) { memset(ip_buf, 0, limit * sizeof(*ip_buf)); +#ifndef TARGET_OS_DARWIN unw_backtrace(ip_buf, limit); +#else + backtrace(ip_buf, limit); +#endif } /** @@ -459,12 +468,12 @@ fast_trace_collect(void **ip_buf, int limit) void fast_trace_foreach(backtrace_cb cb, void **ip_buf, int limit, void *cb_ctx) { +#ifndef TARGET_OS_DARWIN static __thread char proc_name[BACKTRACE_NAME_MAX]; - int frame_no = 0; + char* proc = NULL; + int frame_no = 0, ret = 0; unw_word_t ip = 0, offset = 0; unw_proc_info_t pi; - int ret = 0; - char* proc = NULL; unw_accessors_t* acc = unw_get_accessors(unw_local_addr_space); assert(acc); @@ -489,11 +498,26 @@ fast_trace_foreach(backtrace_cb cb, void **ip_buf, int limit, void *cb_ctx) break; } -#ifndef TARGET_OS_DARWIN if (ret != 0) say_debug("unwinding error: %s", unw_strerror(ret)); #else - if (ret != 0) + int frame_no = 0, ret = 1; + void *ip = NULL; + size_t offset = 0; + Dl_info dli; + + for (frame_no = 0; frame_no < limit && ip_buf[frame_no] != NULL; + ++frame_no) { + ip = ip_buf[frame_no]; + ret = dladdr(ip, &dli); + offset = (char *)ip - (char *)dli.dli_saddr; + + if (frame_no > 0 && + cb(frame_no - 1, ip, dli.dli_sname, offset, cb_ctx) != 0) + break; + } + + if (ret == 0) say_debug("unwinding error: %i", ret); #endif } @@ -502,7 +526,7 @@ void print_backtrace(void) { char *start = (char *)static_alloc(SMALL_STATIC_SIZE); - fdprintf(STDERR_FILENO, "%s", backtrace(start, SMALL_STATIC_SIZE)); + fdprintf(STDERR_FILENO, "%s", backtrace_to_buf(start, SMALL_STATIC_SIZE)); } #endif /* ENABLE_BACKTRACE */ diff --git a/src/lib/core/backtrace.h b/src/lib/core/backtrace.h index 1560f03e3..8bb668366 100644 --- a/src/lib/core/backtrace.h +++ b/src/lib/core/backtrace.h @@ -41,7 +41,7 @@ extern "C" { #include char * -backtrace(char *start, size_t size); +backtrace_to_buf(char *start, size_t size); void print_backtrace(void); diff --git a/src/lib/core/crash.c b/src/lib/core/crash.c index abb7837e6..d1990d68b 100644 --- a/src/lib/core/crash.c +++ b/src/lib/core/crash.c @@ -213,7 +213,7 @@ crash_collect(int signo, siginfo_t *siginfo, void *ucontext) #ifdef ENABLE_BACKTRACE char *start = cinfo->backtrace_buf; - backtrace(start, sizeof(cinfo->backtrace_buf)); + backtrace_to_buf(start, sizeof(cinfo->backtrace_buf)); #endif #ifdef HAS_GREG -- 2.31.1